fixed check of return codes

Author: sanderegg

packages/service-library/src/servicelib/redis/_semaphore.py

@@ -216,7 +216,7 @@ async def release(self) -> None:
         result = status
 
         if result == "released":
-            assert exit_code == SCRIPT_BAD_EXIT_CODE  # nosec
+            assert exit_code == SCRIPT_OK_EXIT_CODE  # nosec
             _logger.debug(
                 "Released semaphore '%s' (instance: %s, count: %s, expired: %s)",
                 self.key,
@@ -227,7 +227,7 @@ async def release(self) -> None:
         else:
             # Instance wasn't in the semaphore set - this shouldn't happen
             # but let's handle it gracefully
-            assert exit_code == SCRIPT_OK_EXIT_CODE  # nosec
+            assert exit_code == SCRIPT_BAD_EXIT_CODE  # nosec
             raise SemaphoreNotAcquiredError(name=self.key)
 
     async def _try_acquire(self) -> bool:

packages/service-library/src/servicelib/redis/lua/release_semaphore.lua

@@ -29,7 +29,7 @@ local score = redis.call('ZSCORE', semaphore_key, instance_id)
 if score == false then
     -- Instance doesn't hold the semaphore
     local current_count = redis.call('ZCARD', semaphore_key)
-    return {0, 'not_held', current_count, expired_count}
+    return {255, 'not_held', current_count, expired_count}
 end
 
 -- Step 3: Remove the semaphore entry and holder key