Skip to content

Commit 59ead7a

Browse files
committed
@pcrespov generator -> iterator
1 parent 0822e01 commit 59ead7a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

services/api-server/src/simcore_service_api_server/core/_prometheus_instrumentation.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import logging
2-
from collections.abc import Generator
2+
from collections.abc import Iterator
33
from dataclasses import dataclass, field
44
from datetime import timedelta
55
from typing import Final, cast
@@ -49,18 +49,18 @@ def __post_init__(self) -> None:
4949

5050
def update_metrics(
5151
self,
52-
log_queue_sizes: Generator[tuple[JobID, int]],
52+
iter_log_queue_sizes: Iterator[tuple[JobID, int]],
5353
health_check_failure_count: PositiveInt,
5454
):
5555
self._health_check_qauge.set(health_check_failure_count)
5656
self._logstreaming_queues.clear()
57-
for job_id, length in log_queue_sizes:
57+
for job_id, length in iter_log_queue_sizes:
5858
self._logstreaming_queues.labels(job_id=job_id).set(length)
5959

6060

6161
async def _collect_prometheus_metrics_task(app: FastAPI):
6262
get_instrumentation(app).update_metrics(
63-
log_queue_sizes=get_log_distributor(app).log_queue_sizes,
63+
iter_log_queue_sizes=get_log_distributor(app).iter_log_queue_sizes,
6464
health_check_failure_count=get_health_checker(app).health_check_failure_count,
6565
)
6666

services/api-server/src/simcore_service_api_server/services_http/log_streaming.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import asyncio
22
import logging
33
from asyncio import Queue
4-
from collections.abc import AsyncIterable, Generator
4+
from collections.abc import AsyncIterable, Iterator
55
from typing import Final
66

77
from common_library.error_codes import create_error_code
@@ -86,7 +86,7 @@ async def deregister(self, job_id: JobID):
8686
del self._log_streamers[job_id]
8787

8888
@property
89-
def log_queue_sizes(self) -> Generator[tuple[JobID, int]]:
89+
def iter_log_queue_sizes(self) -> Iterator[tuple[JobID, int]]:
9090
for k, v in self._log_streamers.items():
9191
yield k, v.qsize()
9292

0 commit comments

Comments
 (0)