Skip to content

Commit 5ad5018

Browse files
committed
[skip ci] refactor
1 parent 5e75847 commit 5ad5018

File tree

3 files changed

+29
-17
lines changed

3 files changed

+29
-17
lines changed

services/static-webserver/client/source/class/osparc/data/model/User.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ qx.Class.define("osparc.data.model.User", {
4141
}
4242
const thumbnail = osparc.utils.Avatar.emailToThumbnail(userData["login"], userData["userName"]);
4343
this.set({
44-
userId: parseInt(userData["id"]),
45-
groupId: parseInt(userData["gid"]),
44+
userId: ("id" in userData) ? parseInt(userData["id"]) : parseInt(userData["userId"]),
45+
groupId: ("gid" in userData) ? parseInt(userData["gid"]) : parseInt(userData["groupId"]),
4646
username: userData["userName"],
47-
firstName: userData["first_name"],
48-
lastName: userData["last_name"],
49-
email: userData["login"],
47+
firstName: ("first_name" in userData) ? userData["first_name"] : userData["firstName"],
48+
lastName: ("last_name" in userData) ? userData["last_name"] : userData["lastName"],
49+
email: ("login" in userData) ? userData["login"] : userData["email"],
5050
label: userData["userName"],
5151
description,
5252
thumbnail,

services/static-webserver/client/source/class/osparc/share/NewCollaboratorsManager.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,14 @@ qx.Class.define("osparc.share.NewCollaboratorsManager", {
111111

112112
__searchUsers: function() {
113113
const text = this.__textFilter.getChildControl("textfield").getValue();
114-
const params = {
115-
data: {
116-
match: text
117-
}
118-
};
119-
osparc.data.Resources.fetch("users", "search", params)
120-
.then(data => console.log(data))
114+
osparc.store.Users.getInstance().searchUsers(text)
115+
.then(users => {
116+
console.log(users);
117+
})
121118
.catch(err => {
122119
console.error(err);
123120
osparc.FlashMessenger.getInstance().logAs(err.message, "ERROR");
124-
})
121+
});
125122
},
126123

127124
__reloadCollaborators: function() {

services/static-webserver/client/source/class/osparc/store/Users.js

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,31 @@ qx.Class.define("osparc.store.Users", {
2222
construct: function() {
2323
this.base(arguments);
2424

25-
this.usersCached = [];
25+
this.__usersCached = [];
2626
},
2727

2828
members: {
2929
addUser: function(userData) {
30-
const userFound = this.usersCached.find(user => user.getGroupId() === userData["groupId"]);
30+
const user = new osparc.data.model.User(userData);
31+
const userFound = this.__usersCached.find(usr => usr.getGroupId() === user.getGroupId());
3132
if (!userFound) {
32-
const user = new osparc.data.model.User(userData);
33-
this.usersCached.push(user);
33+
this.__usersCached.push(user);
3434
}
35+
return user;
36+
},
37+
38+
searchUsers: function(text) {
39+
const params = {
40+
data: {
41+
match: text
42+
}
43+
};
44+
return osparc.data.Resources.fetch("users", "search", params)
45+
.then(usersData => {
46+
const users = [];
47+
usersData.forEach(userData => users.push(this.addUser(userData)));
48+
return users;
49+
});
3550
},
3651
}
3752
});

0 commit comments

Comments
 (0)