Skip to content

Commit 5ad9ea2

Browse files
committed
@GitHK zipping -> data_export
1 parent 84de735 commit 5ad9ea2

File tree

4 files changed

+23
-23
lines changed

4 files changed

+23
-23
lines changed

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/zipping.py renamed to packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/storage/data_export.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,51 +21,51 @@
2121
_RPC_METHOD_NAME_ADAPTER = TypeAdapter(RPCMethodName)
2222

2323

24-
async def start_zipping(
24+
async def start_data_export(
2525
rabbitmq_rpc_client: RabbitMQRPCClient, *, paths: ZipTaskStartInput
2626
) -> TaskRpcGet:
2727
result = await rabbitmq_rpc_client.request(
2828
STORAGE_RPC_NAMESPACE,
29-
_RPC_METHOD_NAME_ADAPTER.validate_python("start_zipping"),
29+
_RPC_METHOD_NAME_ADAPTER.validate_python("start_data_export"),
3030
paths=paths,
3131
timeout_s=_DEFAULT_TIMEOUT_S,
3232
)
3333
assert isinstance(result, TaskRpcGet)
3434
return result
3535

3636

37-
async def abort_zipping(
37+
async def abort_data_export(
3838
rabbitmq_rpc_client: RabbitMQRPCClient, *, task_id: TaskRpcId
3939
) -> ZipTaskAbortOutput:
4040
result = await rabbitmq_rpc_client.request(
4141
STORAGE_RPC_NAMESPACE,
42-
_RPC_METHOD_NAME_ADAPTER.validate_python("abort_zipping"),
42+
_RPC_METHOD_NAME_ADAPTER.validate_python("abort_data_export"),
4343
task_id=task_id,
4444
timeout_s=_DEFAULT_TIMEOUT_S,
4545
)
4646
assert isinstance(result, ZipTaskAbortOutput)
4747
return result
4848

4949

50-
async def get_zipping_status(
50+
async def get_data_export_status(
5151
rabbitmq_rpc_client: RabbitMQRPCClient, *, task_id: TaskRpcId
5252
) -> TaskRpcStatus:
5353
result = await rabbitmq_rpc_client.request(
5454
STORAGE_RPC_NAMESPACE,
55-
_RPC_METHOD_NAME_ADAPTER.validate_python("get_zipping_status"),
55+
_RPC_METHOD_NAME_ADAPTER.validate_python("get_data_export_status"),
5656
task_id=task_id,
5757
timeout_s=_DEFAULT_TIMEOUT_S,
5858
)
5959
assert isinstance(result, TaskRpcStatus)
6060
return result
6161

6262

63-
async def get_zipping_result(
63+
async def get_data_export_result(
6464
rabbitmq_rpc_client: RabbitMQRPCClient, *, task_id: TaskRpcId
6565
) -> TaskRpcResult:
6666
result = await rabbitmq_rpc_client.request(
6767
STORAGE_RPC_NAMESPACE,
68-
_RPC_METHOD_NAME_ADAPTER.validate_python("get_zipping_result"),
68+
_RPC_METHOD_NAME_ADAPTER.validate_python("get_data_export_result"),
6969
task_id=task_id,
7070
timeout_s=_DEFAULT_TIMEOUT_S,
7171
)

services/storage/src/simcore_service_storage/api/rpc/_zipping.py renamed to services/storage/src/simcore_service_storage/api/rpc/_data_export.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020
@router.expose()
21-
async def start_zipping(app: FastAPI, paths: ZipTaskStartInput) -> TaskRpcGet:
21+
async def start_data_export(app: FastAPI, paths: ZipTaskStartInput) -> TaskRpcGet:
2222
assert app # nosec
2323
return TaskRpcGet(
2424
task_id=uuid4(),
@@ -27,13 +27,13 @@ async def start_zipping(app: FastAPI, paths: ZipTaskStartInput) -> TaskRpcGet:
2727

2828

2929
@router.expose()
30-
async def abort_zipping(app: FastAPI, task_id: TaskRpcId) -> ZipTaskAbortOutput:
30+
async def abort_data_export(app: FastAPI, task_id: TaskRpcId) -> ZipTaskAbortOutput:
3131
assert app # nosec
3232
return ZipTaskAbortOutput(result=True, task_id=task_id)
3333

3434

3535
@router.expose()
36-
async def get_zipping_status(app: FastAPI, task_id: TaskRpcId) -> TaskRpcStatus:
36+
async def get_data_export_status(app: FastAPI, task_id: TaskRpcId) -> TaskRpcStatus:
3737
assert app # nosec
3838
return TaskRpcStatus(
3939
task_id=task_id,
@@ -45,7 +45,7 @@ async def get_zipping_status(app: FastAPI, task_id: TaskRpcId) -> TaskRpcStatus:
4545

4646

4747
@router.expose()
48-
async def get_zipping_result(app: FastAPI, task_id: TaskRpcId) -> TaskRpcResult:
48+
async def get_data_export_result(app: FastAPI, task_id: TaskRpcId) -> TaskRpcResult:
4949
assert app # nosec
5050
assert task_id # nosec
5151
return TaskRpcResult(result="Here's your result.", error=None)

services/storage/src/simcore_service_storage/api/rpc/routes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
from servicelib.rabbitmq import RPCRouter
77

88
from ...modules.rabbitmq import get_rabbitmq_rpc_server
9-
from . import _zipping
9+
from . import _data_export
1010

1111
_logger = logging.getLogger(__name__)
1212

1313

14-
ROUTERS: list[RPCRouter] = [_zipping.router]
14+
ROUTERS: list[RPCRouter] = [_data_export.router]
1515

1616

1717
def setup_rpc_api_routes(app: FastAPI) -> None:

services/storage/tests/unit/test_zipping.py renamed to services/storage/tests/unit/test_data_export.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from pytest_simcore.helpers.monkeypatch_envs import setenvs_from_dict
2121
from pytest_simcore.helpers.typing_env import EnvVarsDict
2222
from servicelib.rabbitmq import RabbitMQRPCClient
23-
from servicelib.rabbitmq.rpc_interfaces.storage import zipping
23+
from servicelib.rabbitmq.rpc_interfaces.storage import data_export
2424
from settings_library.rabbit import RabbitSettings
2525
from simcore_service_storage.core.settings import ApplicationSettings
2626

@@ -73,28 +73,28 @@ async def rpc_client(
7373
return await rabbitmq_rpc_client("client")
7474

7575

76-
async def test_start_zipping(rpc_client: RabbitMQRPCClient, faker: Faker):
77-
result = await zipping.start_zipping(
76+
async def test_start_data_export(rpc_client: RabbitMQRPCClient, faker: Faker):
77+
result = await data_export.start_data_export(
7878
rpc_client, paths=ZipTaskStartInput(paths=[Path(faker.file_path())])
7979
)
8080
assert isinstance(result, TaskRpcGet)
8181

8282

83-
async def test_abort_zipping(rpc_client: RabbitMQRPCClient, faker: Faker):
83+
async def test_abort_data_export(rpc_client: RabbitMQRPCClient, faker: Faker):
8484
_task_id = TaskRpcId(faker.uuid4())
85-
result = await zipping.abort_zipping(rpc_client, task_id=_task_id)
85+
result = await data_export.abort_data_export(rpc_client, task_id=_task_id)
8686
assert isinstance(result, ZipTaskAbortOutput)
8787
assert result.task_id == _task_id
8888

8989

90-
async def test_get_zipping_status(rpc_client: RabbitMQRPCClient, faker: Faker):
90+
async def test_get_data_export_status(rpc_client: RabbitMQRPCClient, faker: Faker):
9191
_task_id = TaskRpcId(faker.uuid4())
92-
result = await zipping.get_zipping_status(rpc_client, task_id=_task_id)
92+
result = await data_export.get_data_export_status(rpc_client, task_id=_task_id)
9393
assert isinstance(result, TaskRpcStatus)
9494
assert result.task_id == _task_id
9595

9696

97-
async def test_get_zipping_result(rpc_client: RabbitMQRPCClient, faker: Faker):
97+
async def test_get_data_export_result(rpc_client: RabbitMQRPCClient, faker: Faker):
9898
_task_id = TaskRpcId(faker.uuid4())
99-
result = await zipping.get_zipping_result(rpc_client, task_id=_task_id)
99+
result = await data_export.get_data_export_result(rpc_client, task_id=_task_id)
100100
assert isinstance(result, TaskRpcResult)

0 commit comments

Comments
 (0)