improves error handling

Author: pcrespov

services/web/server/src/simcore_service_webserver/studies_dispatcher/_errors.py

@@ -1,31 +1,38 @@
+from common_library.user_messages import user_message
+
 from ..errors import WebServerBaseError
 
 
 class StudyDispatcherError(WebServerBaseError, ValueError): ...
 
 
 class IncompatibleServiceError(StudyDispatcherError):
-    msg_template = "None of the registered services can handle '{file_type}'"
+    msg_template = user_message(
+        "None of the registered services can handle '{file_type}'"
+    )
 
 
 class FileToLargeError(StudyDispatcherError):
-    msg_template = "File size {file_size_in_mb} MB is over allowed limit"
+    msg_template = user_message("File size {file_size_in_mb} MB is over allowed limit")
 
 
 class ServiceNotFoundError(StudyDispatcherError):
-    msg_template = "Service {service_key}:{service_version} not found"
+    msg_template = user_message("Service {service_key}:{service_version} not found")
 
 
 class InvalidRedirectionParamsError(StudyDispatcherError):
-    msg_template = (
-        "The link you provided is invalid because it doesn't contain any information related to data or a service."
-        " Please check the link and make sure it is correct."
-    )
+    msg_template = "Invalid link"
 
 
 class GuestUsersLimitError(StudyDispatcherError):
-    msg_template = "Maximum number of guests was reached. Please login with a registered user or try again later"
+    msg_template = user_message(
+        "Maximum number of guests was reached. Please login with a registered user or try again later"
+    )
 
 
 class GuestUserNotAllowedError(StudyDispatcherError):
     msg_template = "Guest users are not allowed to access this resource configuration."
+
+
+class ProjectWorkbenchMismatchError(StudyDispatcherError):
+    msg_template = "Project {project_uuid} exists but does not seem to be a viewer generated by this module"

services/web/server/src/simcore_service_webserver/studies_dispatcher/_projects.py

@@ -19,14 +19,14 @@
 from models_library.projects_nodes_io import DownloadLink, NodeID, PortLink
 from models_library.services import ServiceKey, ServiceVersion
 from pydantic import AnyUrl, HttpUrl, TypeAdapter
-from servicelib.logging_errors import create_troubleshootting_log_kwargs
 from servicelib.logging_utils import log_decorator
 
 from ..projects._projects_repository_legacy import ProjectDBAPI
 from ..projects._projects_service import get_project_for_user
 from ..projects.exceptions import ProjectInvalidRightsError, ProjectNotFoundError
 from ..utils import now_str
 from ._core import compose_uuid_from
+from ._errors import ProjectWorkbenchMismatchError
 from ._models import FileParams, ServiceInfo, ViewerInfo
 from ._users import UserInfo
 
@@ -282,24 +282,14 @@ async def get_or_create_project_with_file_and_service(
         if is_valid:
             exists = True
         else:
-            http_500_error = web.HTTPInternalServerError()
-            _logger.error(
-                **create_troubleshootting_log_kwargs(
-                    f"Project {project_uid} exists but does not seem to be a viewer generated by this module.",
-                    error=http_500_error,
-                    error_context={
-                        "user": user,
-                        "viewer": viewer,
-                        "download_link": download_link,
-                        "project_db_workbench_keys": list(
-                            project_db.get("workbench", {}).keys()
-                        ),
-                        "expected_keys": [file_picker_id, service_id],
-                    },
-                )
+            raise ProjectWorkbenchMismatchError(
+                project_uuid=project_uid,
+                user=user,
+                viewer=viewer,
+                download_link=download_link,
+                project_db_workbench_keys=list(project_db.get("workbench", {}).keys()),
+                expected_keys=[file_picker_id, service_id],
             )
-            # FIXME: CANNOT GUARANTEE!!, DELETE?? ERROR?? and cannot be viewed until verified?
-            raise http_500_error
 
     except (ProjectNotFoundError, ProjectInvalidRightsError):
         exists = False

services/web/server/src/simcore_service_webserver/studies_dispatcher/_redirects_handlers.py

@@ -7,6 +7,8 @@
 
 from aiohttp import web
 from common_library.error_codes import create_error_code
+from common_library.user_messages import user_message
+from models_library.function_services_catalog._utils import ServiceNotFound
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import NodeID
 from models_library.services import ServiceKey, ServiceVersion
@@ -25,9 +27,12 @@
 from ._constants import MSG_GUESTS_NOT_ALLOWED, MSG_UNEXPECTED_DISPATCH_ERROR
 from ._core import validate_requested_file, validate_requested_viewer
 from ._errors import (
+    FileToLargeError,
     GuestUserNotAllowedError,
+    GuestUsersLimitError,
+    IncompatibleServiceError,
     InvalidRedirectionParamsError,
-    StudyDispatcherError,
+    ProjectWorkbenchMismatchError,
 )
 from ._models import FileParams, ServiceInfo, ServiceParams, ViewerInfo
 from ._projects import (
@@ -104,18 +109,49 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
                 status_code=status.HTTP_401_UNAUTHORIZED,
             ) from err
 
-        except StudyDispatcherError as err:
+        except ProjectWorkbenchMismatchError as err:
+            error_code = create_error_code(err)
+
+            user_error_msg = compose_support_error_msg(
+                msg=MSG_UNEXPECTED_DISPATCH_ERROR, error_code=error_code
+            )
+            _logger.exception(
+                **create_troubleshootting_log_kwargs(
+                    user_error_msg,
+                    error=err,
+                    error_code=error_code,
+                    error_context=create_error_context_from_request(request),
+                    tip="project might be corrupted",
+                )
+            )
+            raise _create_redirect_response_to_error_page(
+                request.app,
+                message=user_error_msg,
+                status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            ) from err
+
+        except (
+            ServiceNotFound,
+            FileToLargeError,
+            IncompatibleServiceError,
+            GuestUsersLimitError,
+        ) as err:
+            user_error_msg = f"Sorry, we cannot dispatch your study: {err}"
             raise _create_redirect_response_to_error_page(
                 request.app,
-                message=f"Sorry, we cannot dispatch your study: {err}",
+                message=user_error_msg,
                 status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,  # 422
             ) from err
 
-        except web.HTTPUnprocessableEntity as err:
+        except (InvalidRedirectionParamsError, web.HTTPUnprocessableEntity) as err:
             # Validation error in query parameters
             error_code = create_error_code(err)
             user_error_msg = compose_support_error_msg(
-                msg="Invalid query parameters in link", error_code=error_code
+                msg=user_message(
+                    "The link you provided is invalid because it doesn't contain any or invalid information related to data or a service."
+                    "Please check the link and make sure it is correct."
+                ),
+                error_code=error_code,
             )
 
             _logger.exception(