Skip to content

Commit 5b706d8

Browse files
committed
fix yet another model
1 parent 2309964 commit 5b706d8

File tree

2 files changed

+10
-6
lines changed
  • packages/models-library/src/models_library/api_schemas_webserver
  • services/api-server/src/simcore_service_api_server/models/schemas

2 files changed

+10
-6
lines changed

packages/models-library/src/models_library/api_schemas_webserver/product.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ class GetCreditPrice(OutputSchema):
2626
...,
2727
description="Price of a credit in USD. "
2828
"If None, then this product's price is UNDEFINED",
29-
)
29+
) # TODO: should be nullable
3030
min_payment_amount_usd: NonNegativeInt = Field(
3131
...,
3232
description="Minimum amount (included) in USD that can be paid for this product"
3333
"Can be None if this product's price is UNDEFINED",
34-
)
34+
) # TODO: should be nullable
3535

3636
model_config = ConfigDict(
3737
json_schema_extra={

services/api-server/src/simcore_service_api_server/models/schemas/files.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ class ClientFile(BaseModel):
3333
"""Represents a file stored on the client side"""
3434

3535
filename: FileName = Field(..., description="File name")
36-
filesize: ByteSize = Field(..., description="File size in bytes")
36+
filesize: int = Field(
37+
..., description="File size in bytes"
38+
) # TODO: should probably be a NonNegativeInt
3739
sha256_checksum: SHA256Str = Field(..., description="SHA256 checksum")
3840

3941

@@ -50,13 +52,15 @@ class File(BaseModel):
5052
default=None,
5153
description="Guess of type content [EXPERIMENTAL]",
5254
validate_default=True,
53-
)
55+
) # TODO: should be nullable
5456
sha256_checksum: SHA256Str = Field(
5557
default=None,
5658
description="SHA256 hash of the file's content",
5759
alias="checksum", # alias for backwards compatibility
58-
)
59-
e_tag: ETag = Field(default=None, description="S3 entity tag")
60+
) # TODO: should be nullable
61+
e_tag: ETag = Field(
62+
default=None, description="S3 entity tag"
63+
) # TODO: should be nullable
6064

6165
model_config = ConfigDict(
6266
populate_by_name=True,

0 commit comments

Comments
 (0)