fix code smells

Author: giancarloromeo

packages/settings-library/src/settings_library/postgres.py

@@ -49,7 +49,7 @@ class PostgresSettings(BaseCustomSettings):
     @field_validator("POSTGRES_MAXSIZE")
     @classmethod
     def _check_size(cls, v, info: ValidationInfo):
-        if not (info.data["POSTGRES_MINSIZE"] <= v):
+        if info.data["POSTGRES_MINSIZE"] > v:
             msg = f"assert POSTGRES_MINSIZE={info.data['POSTGRES_MINSIZE']} <= POSTGRES_MAXSIZE={v}"
             raise ValueError(msg)
         return v

packages/settings-library/src/settings_library/utils_cli.py

@@ -60,9 +60,8 @@ def print_as_envfile(
         elif show_secrets and hasattr(value, "get_secret_value"):
             value = value.get_secret_value()
 
-        if verbose:
-            if field.description:
-                typer.echo(f"# {field.description}")
+        if verbose and field.description:
+            typer.echo(f"# {field.description}")
 
         typer.echo(f"{name}={value}")
 

packages/simcore-sdk/src/simcore_sdk/node_ports_v2/ports_mapping.py

@@ -9,9 +9,8 @@
 
 class BasePortsMapping(RootModel[dict[ServicePortKey, Port]]):
     def __getitem__(self, key: int | ServicePortKey) -> Port:
-        if isinstance(key, int):
-            if key < len(self.root):
-                key = list(self.root.keys())[key]
+        if isinstance(key, int) and key < len(self.root):
+            key = list(self.root.keys())[key]
         if key not in self.root:
             raise UnboundPortError(key)
         assert isinstance(key, str)  # nosec