refactor to common validators

Author: Andrei Neagu

packages/common-library/src/common_library/pydantic_validators.py

@@ -1,5 +1,6 @@
 import datetime
 
+from models_library.services_types import RunID
 from pydantic import field_validator
 
 
@@ -18,3 +19,13 @@ def _try_convert_str_to_float_or_return(
 def timedelta_try_convert_str_to_float(field: str):
     """Transforms a float/int number into a valid datetime as it used to work in the past"""
     return field_validator(field, mode="before")(_try_convert_str_to_float_or_return)
+
+
+def _convert_str_to_run_id_object(v: RunID | str) -> RunID:
+    if isinstance(v, str):
+        return RunID(v)
+    return v
+
+
+def convert_str_to_run_id_object(field: str):
+    return field_validator(field, mode="before")(_convert_str_to_run_id_object)

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py

@@ -5,7 +5,10 @@
 from typing import cast
 
 from common_library.pydantic_type_adapters import ByteSizeAdapter
-from common_library.pydantic_validators import timedelta_try_convert_str_to_float
+from common_library.pydantic_validators import (
+    convert_str_to_run_id_object,
+    timedelta_try_convert_str_to_float,
+)
 from models_library.basic_types import BootModeEnum, PortInt
 from models_library.callbacks_mapping import CallbacksMapping
 from models_library.products import ProductName
@@ -189,18 +192,13 @@ def are_prometheus_metrics_enabled(self) -> bool:
             self.DY_SIDECAR_CALLBACKS_MAPPING.metrics is not None
         )
 
-    @field_validator("DY_SIDECAR_RUN_ID", mode="before")
-    @classmethod
-    def convert_str_to_run_id_object(cls, v):
-        if isinstance(v, str):
-            return RunID(v)
-        return v
-
     @field_validator("LOG_LEVEL")
     @classmethod
     def _check_log_level(cls, value):
         return cls.validate_log_level(value)
 
+    _convert_str_to_run_id_object = convert_str_to_run_id_object("DY_SIDECAR_RUN_ID")
+
     _try_convert_dynamic_sidecar_telemetry_disk_usage_monitor_interval = (
         timedelta_try_convert_str_to_float(
             "DYNAMIC_SIDECAR_TELEMETRY_DISK_USAGE_MONITOR_INTERVAL"