add some more use cases

Author: sanderegg

services/storage/tests/conftest.py

@@ -561,14 +561,22 @@ async def _create_content(
 
         # Create subdirectories
         s3_base_path = Path(f"{project_id}") / f"{node_id}" / dir_name
-        s3_subdirs = [s3_base_path / f"sub-dir-{i}" for i in range(subdir_count)]
+        # NOTE: add a space in the sub directory
+        s3_subdirs = [
+            s3_base_path / f"sub-dir_ect ory-{i}" for i in range(subdir_count)
+        ]
         # Randomly distribute files across subdirectories
         selected_subdirs = random.choices(s3_subdirs, k=file_count)  # noqa: S311
         # Upload to S3
         with log_context(
             logging.INFO,
             msg=f"Uploading {file_count} files to S3 (each {file_size_in_dir.human_readable()}, total: {ByteSize(file_count * file_size_in_dir).human_readable()})",
         ):
+            # we ensure the file name contain a space
+            def _file_name_with_space():
+                file_name = faker.unique.file_name()
+                return f"{file_name[:1]} {file_name[1:]}"
+
             results = await asyncio.gather(
                 *(
                     _upload_file_to_s3(
@@ -577,7 +585,7 @@ async def _create_content(
                         s3_bucket=storage_s3_bucket,
                         local_file=local_file,
                         file_id=TypeAdapter(SimcoreS3FileID).validate_python(
-                            f"{selected_subdir / faker.unique.file_name()}"
+                            f"{selected_subdir / _file_name_with_space()}"
                         ),
                     )
                     for selected_subdir in selected_subdirs

services/storage/tests/unit/test_handlers_paths.py

@@ -371,7 +371,7 @@ async def test_list_paths(
         ProjectWithFilesParams(
             num_nodes=1,
             allowed_file_sizes=(TypeAdapter(ByteSize).validate_python("0b"),),
-            workspace_files_count=0,
+            workspace_files_count=10,
         )
     ],
     ids=str,
@@ -449,3 +449,38 @@ async def test_list_paths_with_display_name_containing_slashes(
     ) / quote(
         node_name_with_non_ascii, safe=""
     ), "display path parts should be url encoded"
+
+    # ls in the node workspace
+    selected_node_id = NodeID(random.choice(list(project["workbench"])))  # noqa: S311
+    selected_node_s3_keys = [
+        Path(s3_object_id) for s3_object_id in list_of_files[selected_node_id]
+    ]
+    workspace_file_filter = file_filter / f"{selected_node_id}" / "workspace"
+    expected_paths = _filter_and_group_paths_one_level_deeper(
+        selected_node_s3_keys, workspace_file_filter
+    )
+    await _assert_list_paths(
+        initialized_app,
+        client,
+        location_id,
+        user_id,
+        file_filter=workspace_file_filter,
+        expected_paths=expected_paths,
+        check_total=False,
+    )
+
+    # ls in until we get to some files
+    while selected_subfolders := [p for p in expected_paths if p[1] is False]:
+        selected_path_filter = random.choice(selected_subfolders)  # noqa: S311
+        expected_paths = _filter_and_group_paths_one_level_deeper(
+            selected_node_s3_keys, selected_path_filter[0]
+        )
+        await _assert_list_paths(
+            initialized_app,
+            client,
+            location_id,
+            user_id,
+            file_filter=selected_path_filter[0],
+            expected_paths=expected_paths,
+            check_total=False,
+        )