the test passes

Author: sanderegg

services/storage/tests/unit/test__legacy_storage_sdk_compatibility.py

@@ -11,23 +11,89 @@
 used in simcore_sdk since legacy services are planned to be deprecated.
 """
 
+import logging
 from pathlib import Path
+from threading import Thread
+from typing import AsyncIterator
 
 import aiohttp
+import httpx
 import pytest
+import uvicorn
 from faker import Faker
-from fastapi import FastAPI
-from httpx import AsyncClient
 from models_library.projects_nodes_io import LocationID, SimcoreS3FileID
 from models_library.users import UserID
+from pytest_simcore.helpers.logging_tools import log_context
+from servicelib.utils import unused_port
+from simcore_service_storage._meta import API_VTAG
+from simcore_service_storage.core.application import create_app
+from simcore_service_storage.core.settings import ApplicationSettings
 from simcore_service_storage.simcore_s3_dsm import SimcoreS3DataManager
 from simcore_service_storage_sdk import ApiClient, Configuration, UsersApi
+from tenacity import (
+    before_sleep_log,
+    retry,
+    retry_if_exception_type,
+    stop_after_delay,
+    wait_fixed,
+)
+from yarl import URL
 
 pytest_simcore_core_services_selection = ["postgres"]
 pytest_simcore_ops_services_selection = [
     "adminer",
 ]
 
+_logger = logging.getLogger(__name__)
+
+
+@retry(
+    wait=wait_fixed(1),
+    stop=stop_after_delay(10),
+    retry=retry_if_exception_type(),
+    reraise=True,
+    before_sleep=before_sleep_log(_logger, logging.WARNING),
+)
+async def _wait_for_server_ready(server: URL) -> None:
+    async with httpx.AsyncClient(follow_redirects=True) as client:
+        response = await client.get(f"{server}")
+        response.raise_for_status()
+
+
+@pytest.fixture
+async def real_storage_server(app_settings: ApplicationSettings) -> AsyncIterator[URL]:
+    settings = ApplicationSettings.create_from_envs()
+    app = create_app(settings)
+    storage_port = unused_port()
+    with log_context(
+        logging.INFO,
+        msg=f"with fake storage server on 127.0.0.1:{storage_port}/{API_VTAG}",
+    ) as ctx:
+        config = uvicorn.Config(
+            app,
+            host="127.0.0.1",
+            port=storage_port,
+            log_level="error",
+        )
+        server = uvicorn.Server(config)
+
+        thread = Thread(target=server.run)
+        thread.daemon = True
+        thread.start()
+
+        ctx.logger.info(
+            "health at : %s",
+            f"http://127.0.0.1:{storage_port}/{API_VTAG}",
+        )
+        server_url = URL(f"http://127.0.0.1:{storage_port}")
+
+        await _wait_for_server_ready(server_url / API_VTAG)
+
+        yield server_url
+
+        server.should_exit = True
+        thread.join(timeout=10)
+
 
 @pytest.fixture
 def str_user_id(user_id: UserID) -> str:
@@ -55,10 +121,8 @@ def location_name() -> str:
     return SimcoreS3DataManager.get_location_name()
 
 
-@pytest.mark.skip(reason="legacy service")
-async def test_storage_client_used_in_simcore_sdk_0_3_2(  # noqa: PLR0915
-    initialized_app: FastAPI,
-    client: AsyncClient,
+async def test_storage_client_used_in_simcore_sdk_0_3_2(
+    real_storage_server: URL,
     str_user_id: str,
     file_id: str,
     location_id: int,
@@ -79,7 +143,7 @@ async def test_storage_client_used_in_simcore_sdk_0_3_2(  # noqa: PLR0915
 
     # --------
     cfg = Configuration()
-    cfg.host = f"http://{client.base_url.host}:{client.base_url.port or '80'}/v0"
+    cfg.host = f"{real_storage_server / API_VTAG}"
     cfg.debug = True
 
     # assert cfg.host == f"{client.make_url('/v0')}"