Skip to content

Commit 62c4deb

Browse files
author
Andrei Neagu
committed
refactor
1 parent 02eaab2 commit 62c4deb

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

services/dynamic-scheduler/tests/unit/api_frontend/_common/test_updatable_component.py

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import nicegui
99
import pytest
1010
from fastapi import FastAPI
11-
from helpers import assert_contains_text, assert_not_contains_text, take_screenshot
11+
from helpers import assert_contains_text, assert_not_contains_text
1212
from nicegui import APIRouter, ui
1313
from playwright.async_api import Page
1414
from pydantic import NonNegativeInt
@@ -339,47 +339,41 @@ def _index_corpus() -> None:
339339

340340
await ensure_page_loaded(_index_corpus)
341341

342-
await take_screenshot(async_page, prefix="1.before")
343-
344342
person_1 = Person(name="Alice", age=30, companion=Pet(name="Fluffy", species="cat"))
345343
person_2 = Person(name="Bob", age=25, companion=Friend(name="Marta", age=28))
346344

345+
# nothing is displayed
347346
await _ensure_person_not_present(async_page, person_1)
348347
await _ensure_person_not_present(async_page, person_2)
349348

350349
stack.add_or_update_model("person_1", person_1)
351350
stack.add_or_update_model("person_2", person_2)
352351

352+
# both persons are displayed
353353
await _ensure_person_is_present(async_page, person_1)
354354
await _ensure_person_is_present(async_page, person_2)
355355

356-
await take_screenshot(async_page, prefix="2.persons-added")
357-
356+
# only person_2 is displayed
358357
stack.remove_model("person_1")
359358
await _ensure_person_not_present(async_page, person_1)
360359
await _ensure_person_is_present(async_page, person_2)
361360

362-
await take_screenshot(async_page, prefix="3.person-1-removed")
363-
361+
# no person is displayed
364362
stack.remove_model("person_2")
365363
await _ensure_person_not_present(async_page, person_2)
366364
await _ensure_person_not_present(async_page, person_1)
367365

368-
await take_screenshot(async_page, prefix="4.person-2-removed")
369-
366+
# add both persons again together
370367
stack.update_from_dict({"person_1": person_1, "person_2": person_2})
371368
await _ensure_person_is_present(async_page, person_1)
372369
await _ensure_person_is_present(async_page, person_2)
373370

374-
await take_screenshot(async_page, prefix="5.persons-added")
375-
371+
# only person_1 is displayed
376372
stack.update_from_dict({"person_1": person_1})
377373
await _ensure_person_is_present(async_page, person_1)
378374
await _ensure_person_not_present(async_page, person_2)
379375

380-
await take_screenshot(async_page, prefix="6.person-2-removed")
381-
376+
# no person is displayed
382377
stack.update_from_dict({})
383378
await _ensure_person_not_present(async_page, person_1)
384379
await _ensure_person_not_present(async_page, person_2)
385-
await take_screenshot(async_page, prefix="7.person-1-removed")

0 commit comments

Comments
 (0)