Skip to content

Commit 64ec4e7

Browse files
author
Andrei Neagu
committed
remove legacy cookie and renamed cookie
1 parent d7026b7 commit 64ec4e7

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/settings-library/src/settings_library/utils_session.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
import binascii
33
from typing import Final
44

5-
DEFAULT_SESSION_COOKIE_NAME: Final[str] = "osparc-sc"
5+
DEFAULT_SESSION_COOKIE_NAME: Final[str] = "osparc-sc-v2"
6+
DEFAULT_SESSION_COOKIE_NAME_LEGACY: Final[str] = "osparc-sc"
67
_32_BYTES_LENGTH: Final[int] = 32
78

89

services/web/server/src/simcore_service_webserver/login/_auth_handlers.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from servicelib.logging_utils import get_log_record_extra, log_context
1111
from servicelib.mimetype_constants import MIMETYPE_APPLICATION_JSON
1212
from servicelib.request_keys import RQT_USERID_KEY
13+
from settings_library.utils_session import DEFAULT_SESSION_COOKIE_NAME_LEGACY
1314
from simcore_postgres_database.models.users import UserRole
1415

1516
from .._meta import API_VTAG
@@ -270,7 +271,9 @@ async def login_2fa(request: web.Request):
270271
# dispose since code was used
271272
await delete_2fa_code(request.app, login_2fa_.email)
272273

273-
return await login_granted_response(request, user=dict(user))
274+
response = await login_granted_response(request, user=dict(user))
275+
response.del_cookie(DEFAULT_SESSION_COOKIE_NAME_LEGACY)
276+
return response
274277

275278

276279
class LogoutBody(InputSchema):

0 commit comments

Comments
 (0)