GitHK review: add stream in all operations that return

Author: pcrespov

services/web/server/src/simcore_service_webserver/folders/_folders_db.py

@@ -74,7 +74,7 @@ async def create(
     ), "Both user_id and workspace_id cannot be provided at the same time. Please provide only one."
 
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(
+        result = await conn.stream(
             folders_v2.insert()
             .values(
                 name=folder_name,
@@ -88,7 +88,7 @@ async def create(
             )
             .returning(*_SELECTION_ARGS)
         )
-        row = result.first()
+        row = await result.first()
         return FolderDB.from_orm(row)
 
 
@@ -174,8 +174,8 @@ async def get(
     )
 
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(query)
-        row = result.first()
+        result = await conn.stream(query)
+        row = await result.first()
         if row is None:
             raise FolderAccessForbiddenError(
                 reason=f"Folder {folder_id} does not exist.",
@@ -211,8 +211,8 @@ async def get_for_user_or_workspace(
         query = query.where(folders_v2.c.workspace_id == workspace_id)
 
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(query)
-        row = result.first()
+        result = await conn.stream(query)
+        row = await result.first()
         if row is None:
             raise FolderAccessForbiddenError(
                 reason=f"User does not have access to the folder {folder_id}. Or folder does not exist.",
@@ -257,8 +257,8 @@ async def update(
         query = query.where(folders_v2.c.folder_id == folders_id_or_ids)
 
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(query)
-        row = result.first()
+        result = await conn.stream(query)
+        row = await result.first()
         if row is None:
             raise FolderNotFoundError(reason=f"Folder {folders_id_or_ids} not found.")
         return FolderDB.from_orm(row)

services/web/server/src/simcore_service_webserver/workspaces/_groups_db.py

@@ -55,7 +55,7 @@ async def create_workspace_group(
     delete: bool,
 ) -> WorkspaceGroupGetDB:
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(
+        result = await conn.stream(
             workspaces_access_rights.insert()
             .values(
                 workspace_id=workspace_id,
@@ -68,7 +68,7 @@ async def create_workspace_group(
             )
             .returning(literal_column("*"))
         )
-        row = result.first()
+        row = await result.first()
         return WorkspaceGroupGetDB.from_orm(row)
 
 
@@ -120,8 +120,8 @@ async def get_workspace_group(
     )
 
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(stmt)
-        row = result.first()
+        result = await conn.stream(stmt)
+        row = await result.first()
         if row is None:
             raise WorkspaceGroupNotFoundError(
                 workspace_id=workspace_id, group_id=group_id
@@ -140,7 +140,7 @@ async def update_workspace_group(
     delete: bool,
 ) -> WorkspaceGroupGetDB:
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(
+        result = await conn.stream(
             workspaces_access_rights.update()
             .values(
                 read=read,
@@ -153,7 +153,7 @@ async def update_workspace_group(
             )
             .returning(literal_column("*"))
         )
-        row = result.first()
+        row = await result.first()
         if row is None:
             raise WorkspaceGroupNotFoundError(
                 workspace_id=workspace_id, group_id=group_id

services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py

@@ -59,7 +59,7 @@ async def create_workspace(
     thumbnail: str | None,
 ) -> WorkspaceDB:
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(
+        result = await conn.stream(
             workspaces.insert()
             .values(
                 name=name,
@@ -72,7 +72,7 @@ async def create_workspace(
             )
             .returning(*_SELECTION_ARGS)
         )
-        row = result.first()
+        row = await result.first()
         return WorkspaceDB.from_orm(row)
 
 
@@ -157,8 +157,7 @@ async def list_workspaces_for_user(
     list_query = list_query.offset(offset).limit(limit)
 
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        count_result = await conn.execute(count_query)
-        total_count = count_result.scalar()
+        total_count = await conn.scalar(count_query)
 
         result = await conn.stream(list_query)
         items: list[UserWorkspaceAccessRightsDB] = [
@@ -194,8 +193,8 @@ async def get_workspace_for_user(
     )
 
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(base_query)
-        row = result.first()
+        result = await conn.stream(base_query)
+        row = await result.first()
         if row is None:
             raise WorkspaceAccessForbiddenError(
                 reason=f"User {user_id} does not have access to the workspace {workspace_id}. Or workspace does not exist.",
@@ -214,7 +213,7 @@ async def update_workspace(
     product_name: ProductName,
 ) -> WorkspaceDB:
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-        result = await conn.execute(
+        result = await conn.stream(
             workspaces.update()
             .values(
                 name=name,
@@ -228,7 +227,7 @@ async def update_workspace(
             )
             .returning(*_SELECTION_ARGS)
         )
-        row = result.first()
+        row = await result.first()
         if row is None:
             raise WorkspaceNotFoundError(reason=f"Workspace {workspace_id} not found.")
         return WorkspaceDB.from_orm(row)