increased limit

Author: sanderegg

services/storage/openapi.json

@@ -1047,8 +1047,8 @@
             "required": false,
             "schema": {
               "type": "integer",
-              "maximum": 100,
-              "minimum": 0,
+              "maximum": 1000,
+              "minimum": 1,
               "default": 50,
               "title": "Size"
             }
@@ -1060,7 +1060,7 @@
             "content": {
               "application/json": {
                 "schema": {
-                  "$ref": "#/components/schemas/CursorPage_PathMetaDataGet_"
+                  "$ref": "#/components/schemas/CursorPage__T_Customized_PathMetaDataGet_"
                 }
               }
             }
@@ -1419,7 +1419,7 @@
         ],
         "title": "AppStatusCheck"
       },
-      "CursorPage_PathMetaDataGet_": {
+      "CursorPage__T_Customized_PathMetaDataGet_": {
         "properties": {
           "items": {
             "items": {
@@ -1493,7 +1493,7 @@
         "required": [
           "items"
         ],
-        "title": "CursorPage[PathMetaDataGet]"
+        "title": "CursorPage[~T]Customized[PathMetaDataGet]"
       },
       "DatasetMetaDataGet": {
         "properties": {

services/storage/src/simcore_service_storage/api/rest/_paths.py

@@ -1,10 +1,11 @@
 import logging
 from pathlib import Path
-from typing import Annotated
+from typing import Annotated, TypeVar
 
-from fastapi import APIRouter, Depends
-from fastapi_pagination import create_page
-from fastapi_pagination.cursor import CursorPage, CursorParams
+from fastapi import APIRouter, Depends, Query
+from fastapi_pagination import create_page, resolve_params
+from fastapi_pagination.cursor import CursorPage
+from fastapi_pagination.customization import CustomizedPage, UseParamsFields
 from models_library.api_schemas_storage.storage_schemas import PathMetaDataGet
 from models_library.users import UserID
 
@@ -19,18 +20,34 @@
     ],
 )
 
+T = TypeVar("T")
+
+Page = CustomizedPage[
+    CursorPage[T],
+    # Customizes the maximum value to fit frontend needs
+    UseParamsFields(
+        size=Query(
+            50,
+            ge=1,
+            le=1000,
+            description="Page size",
+        )
+    ),
+]
+
 
 @router.get(
     "/locations/{location_id}/paths",
-    response_model=CursorPage[PathMetaDataGet],
+    response_model=Page[PathMetaDataGet],
 )
 async def list_paths(
-    page_params: Annotated[CursorParams, Depends()],
+    page_params: Annotated[Page.__params_type__, Depends()],
     dsm: Annotated[BaseDataManager, Depends(get_data_manager)],
     user_id: UserID,
     file_filter: Path | None = None,
-):
+) -> Page[PathMetaDataGet]:
     """Returns one level of files (paginated)"""
+    page_params = resolve_params()
     items, next_cursor, total_number = await dsm.list_paths(
         user_id=user_id,
         file_filter=file_filter,

services/storage/tests/unit/test_handlers_paths.py

@@ -203,6 +203,48 @@ async def test_list_paths_pagination(
         )
 
 
+@pytest.mark.parametrize(
+    "project_params",
+    [
+        ProjectWithFilesParams(
+            num_nodes=1,
+            allowed_file_sizes=(TypeAdapter(ByteSize).validate_python("0b"),),
+            workspace_files_count=1000,
+        )
+    ],
+    ids=str,
+)
+async def test_list_paths_pagination_large_page(
+    initialized_app: FastAPI,
+    client: httpx.AsyncClient,
+    location_id: LocationID,
+    user_id: UserID,
+    with_random_project_with_files: tuple[
+        dict[str, Any],
+        dict[NodeID, dict[SimcoreS3FileID, FileIDDict]],
+    ],
+):
+    project, list_of_files = with_random_project_with_files
+    selected_node_id = NodeID(random.choice(list(project["workbench"])))  # noqa: S311
+    selected_node_s3_keys = [
+        Path(s3_object_id) for s3_object_id in list_of_files[selected_node_id]
+    ]
+    workspace_file_filter = Path(project["uuid"]) / f"{selected_node_id}" / "workspace"
+    expected_paths = _filter_and_group_paths_one_level_deeper(
+        selected_node_s3_keys, workspace_file_filter
+    )
+    await _assert_list_paths(
+        initialized_app,
+        client,
+        location_id,
+        user_id,
+        file_filter=workspace_file_filter,
+        expected_paths=expected_paths,
+        check_total=False,
+        limit=1000,
+    )
+
+
 @pytest.mark.parametrize(
     "project_params, num_projects",
     [