Skip to content

Commit 6730d76

Browse files
committed
renaming
1 parent bf540fb commit 6730d76

File tree

5 files changed

+16
-10
lines changed

5 files changed

+16
-10
lines changed

packages/notifications-library/src/notifications_library/_render.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
_logger = logging.getLogger(__name__)
88

99

10-
def create_render_env_from_package(**kwargs):
10+
def create_render_environment_from_notifications_library(**kwargs) -> Environment:
1111
return Environment(
1212
loader=PackageLoader(notifications_library.__name__, "templates"),
1313
autoescape=select_autoescape(["html", "xml"]),
1414
**kwargs
1515
)
1616

1717

18-
def create_render_env_from_folder(top_dir: Path):
18+
def create_render_environment_from_folder(top_dir: Path) -> Environment:
1919
assert top_dir.exists() # nosec
2020
assert top_dir.is_dir() # nosec
2121
return Environment(

packages/notifications-library/tests/email/test_email_events.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@
4242
render_email_parts,
4343
)
4444
from notifications_library._models import ProductData, UserData
45-
from notifications_library._render import create_render_env_from_package
45+
from notifications_library._render import (
46+
create_render_environment_from_notifications_library,
47+
)
4648
from notifications_library.payments import PaymentData
4749
from pydantic import EmailStr
4850
from pydantic.json import pydantic_encoder
@@ -186,7 +188,9 @@ async def test_email_event(
186188
assert product_data.product_name == product_name
187189

188190
parts = render_email_parts(
189-
env=create_render_env_from_package(undefined=StrictUndefined),
191+
env=create_render_environment_from_notifications_library(
192+
undefined=StrictUndefined
193+
),
190194
event_name=event_name,
191195
user=user_data,
192196
product=product_data,
@@ -253,7 +257,9 @@ async def test_email_with_reply_to(
253257
)
254258

255259
parts = render_email_parts(
256-
env=create_render_env_from_package(undefined=StrictUndefined),
260+
env=create_render_environment_from_notifications_library(
261+
undefined=StrictUndefined
262+
),
257263
event_name=event_name,
258264
user=user_data,
259265
product=product_data,

packages/notifications-library/tests/test__render.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33

44
from models_library.products import ProductName
55
from notifications_library._render import (
6-
create_render_env_from_folder,
7-
create_render_env_from_package,
6+
create_render_environment_from_folder,
7+
create_render_environment_from_notifications_library,
88
)
99
from notifications_library._templates import _print_tree, _templates_dir
1010

1111

1212
def test_render_env_from_folder(tmp_path: Path, product_name: ProductName):
1313

14-
pkg_env = create_render_env_from_package()
14+
pkg_env = create_render_environment_from_notifications_library()
1515

1616
top_dir = tmp_path / "consolidated"
1717
top_dir.mkdir()
@@ -22,7 +22,7 @@ def test_render_env_from_folder(tmp_path: Path, product_name: ProductName):
2222

2323
_print_tree(top_dir)
2424

25-
consolidated_env = create_render_env_from_folder(top_dir)
25+
consolidated_env = create_render_environment_from_folder(top_dir)
2626

2727
product_template = consolidated_env.get_template(f"{product_name}/base.html")
2828
common_template = pkg_env.get_template("base.html")

packages/notifications-library/tests/with_db/test__repository.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from models_library.users import UserID
1313
from notifications_library._db import TemplatesRepo, UsersRepo
1414
from notifications_library._models import UserData
15-
from notifications_library._payments_db import PaymentsDataRepo
15+
from notifications_library._payments_repository import PaymentsDataRepo
1616
from sqlalchemy.ext.asyncio.engine import AsyncEngine
1717

1818
pytest_simcore_core_services_selection = [

0 commit comments

Comments
 (0)