Skip to content

Commit 6773ddc

Browse files
authored
🐛Bugfix: Cannot instantiate templates (#6198)
1 parent 7d44591 commit 6773ddc

File tree

4 files changed

+19
-22
lines changed

4 files changed

+19
-22
lines changed

packages/simcore-sdk/tests/integration/test_node_ports_common_aws_s3_cli.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,12 @@ async def dir_downloaded_files_2(tmp_path: Path, faker: Faker) -> AsyncIterator[
250250
(1, parse_obj_as(ByteSize, "1mib"), False),
251251
(2, parse_obj_as(ByteSize, "1mib"), False),
252252
(1, parse_obj_as(ByteSize, "1Gib"), True),
253-
(4, parse_obj_as(ByteSize, "500Mib"), True),
254-
(100, parse_obj_as(ByteSize, "20mib"), True),
253+
pytest.param(
254+
4, parse_obj_as(ByteSize, "500Mib"), True, marks=pytest.mark.heavy_load
255+
),
256+
pytest.param(
257+
100, parse_obj_as(ByteSize, "20mib"), True, marks=pytest.mark.heavy_load
258+
),
255259
],
256260
)
257261
async def test_local_to_remote_to_local(

packages/simcore-sdk/tests/integration/test_node_ports_common_r_clone.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,12 @@ async def dir_downloaded_files_2(tmp_path: Path, faker: Faker) -> AsyncIterator[
262262
(1, parse_obj_as(ByteSize, "1mib"), False),
263263
(2, parse_obj_as(ByteSize, "1mib"), False),
264264
(1, parse_obj_as(ByteSize, "1Gib"), True),
265-
(4, parse_obj_as(ByteSize, "500Mib"), True),
266-
(100, parse_obj_as(ByteSize, "20mib"), True),
265+
pytest.param(
266+
4, parse_obj_as(ByteSize, "500Mib"), True, marks=pytest.mark.heavy_load
267+
),
268+
pytest.param(
269+
100, parse_obj_as(ByteSize, "20mib"), True, marks=pytest.mark.heavy_load
270+
),
267271
],
268272
)
269273
async def test_local_to_remote_to_local(

services/catalog/src/simcore_service_catalog/services/services_api.py

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from models_library.products import ProductName
66
from models_library.rest_pagination import PageLimitInt
77
from models_library.services_access import ServiceGroupAccessRightsV2
8-
from models_library.services_enums import ServiceType
98
from models_library.services_history import Compatibility, ServiceRelease
109
from models_library.services_metadata_published import ServiceMetaDataPublished
1110
from models_library.services_types import ServiceKey, ServiceVersion
@@ -15,39 +14,28 @@
1514
CatalogForbiddenError,
1615
CatalogItemNotFoundError,
1716
)
18-
from simcore_service_catalog.models.services_db import (
17+
18+
from ..db.repositories.services import ServicesRepository
19+
from ..models.services_db import (
1920
ServiceAccessRightsAtDB,
2021
ServiceMetaDataAtDB,
2122
ServiceWithHistoryFromDB,
2223
)
23-
from simcore_service_catalog.services import manifest
24-
from simcore_service_catalog.services.director import DirectorApi
25-
26-
from ..db.repositories.services import ServicesRepository
24+
from ..services import manifest
25+
from ..services.director import DirectorApi
2726
from .compatibility import evaluate_service_compatibility_map
2827
from .function_services import is_function_service
2928

3029
_logger = logging.getLogger(__name__)
3130

3231

33-
def _deduce_service_type_from(key: str) -> ServiceType:
34-
for e in ServiceType:
35-
tag = e.value if e != ServiceType.COMPUTATIONAL else "comp"
36-
if tag in key:
37-
return e
38-
raise ValueError(key)
39-
40-
4132
def _db_to_api_model(
4233
service_db: ServiceWithHistoryFromDB,
4334
access_rights_db: list[ServiceAccessRightsAtDB],
4435
service_manifest: ServiceMetaDataPublished,
4536
compatibility_map: dict[ServiceVersion, Compatibility | None] | None = None,
4637
) -> ServiceGetV2:
4738
compatibility_map = compatibility_map or {}
48-
assert ( # nosec
49-
_deduce_service_type_from(service_db.key) == service_manifest.service_type
50-
)
5139

5240
return ServiceGetV2(
5341
key=service_db.key,

services/storage/src/simcore_service_storage/handlers_files.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ async def get_files_metadata(request: web.Request) -> web.Response:
6868
data: list[FileMetaData] = await dsm.list_files(
6969
user_id=query_params.user_id,
7070
expand_dirs=query_params.expand_dirs,
71-
uuid_filter=query_params.uuid_filter,
71+
uuid_filter=query_params.uuid_filter
72+
or f"{query_params.project_id or ''}", # NOTE: https://github.com/ITISFoundation/osparc-issues/issues/1593
7273
project_id=query_params.project_id,
7374
)
7475
return web.json_response(

0 commit comments

Comments
 (0)