clean

Author: sanderegg

packages/service-library/async_logging_example.py

@@ -240,7 +240,7 @@ def setup_loggers(
 
 
 @asynccontextmanager
-async def setup_async_loggers(
+async def async_loggers_lifespan(
     *,
     log_format_local_dev_enabled: bool,
     logger_filter_mapping: dict[LoggerName, list[MessageSubstring]],
@@ -250,7 +250,7 @@ async def setup_async_loggers(
     Async context manager for non-blocking logging infrastructure.
 
     Usage:
-        async with setup_async_loggers(log_format_local_dev_enabled=True):
+        async with async_loggers_lifespan(log_format_local_dev_enabled=True, logger_filter_mapping={}, tracing_settings=None):
             # Your async application code here
             logger.info("This is non-blocking!")
 

packages/service-library/src/servicelib/logging_utils.py

@@ -13,12 +13,12 @@
     LogExtra,
     LogLevelInt,
     LogMessageStr,
+    async_loggers_lifespan,
     guess_message_log_level,
     log_context,
     log_decorator,
     log_exceptions,
     set_parent_module_log_level,
-    setup_async_loggers,
 )
 from tenacity import (
     AsyncRetrying,
@@ -445,7 +445,7 @@ async def test_setup_async_loggers_basic(
     caplog.clear()
     caplog.set_level(logging.INFO)
 
-    async with setup_async_loggers(
+    async with async_loggers_lifespan(
         log_format_local_dev_enabled=log_format_local_dev_enabled,
         logger_filter_mapping={},  # No filters for this test
         tracing_settings=None,  # No tracing for this test
@@ -468,7 +468,7 @@ async def test_setup_async_loggers_with_filters(
         "test_filtered_logger": ["filtered_message"],
     }
 
-    async with setup_async_loggers(
+    async with async_loggers_lifespan(
         log_format_local_dev_enabled=True,
         logger_filter_mapping=filter_mapping,
         tracing_settings=None,  # No tracing for this test
@@ -503,7 +503,7 @@ async def test_setup_async_loggers_with_tracing_settings(
 
     # Note: We can't easily test actual tracing without setting up OpenTelemetry
     # But we can test that the function accepts the parameter
-    async with setup_async_loggers(
+    async with async_loggers_lifespan(
         log_format_local_dev_enabled=False,
         logger_filter_mapping={},  # No filters for this test
         tracing_settings=None,
@@ -523,7 +523,7 @@ async def test_setup_async_loggers_context_manager_cleanup(
 
     test_logger = logging.getLogger("test_cleanup_logger")
 
-    async with setup_async_loggers(
+    async with async_loggers_lifespan(
         log_format_local_dev_enabled=True,
         logger_filter_mapping={},
         tracing_settings=None,
@@ -547,7 +547,7 @@ def _raise_test_exception():
         raise ValueError(exc_msg)
 
     try:
-        async with setup_async_loggers(
+        async with async_loggers_lifespan(
             log_format_local_dev_enabled=True,
             logger_filter_mapping={},
             tracing_settings=None,

packages/service-library/tests/test_logging_utils.py

@@ -21,7 +21,7 @@
 import typer
 from aiohttp import web
 from common_library.json_serialization import json_dumps
-from servicelib.logging_utils import setup_async_loggers
+from servicelib.logging_utils import async_loggers_lifespan
 from settings_library.utils_cli import create_settings_command
 
 from .application_settings import ApplicationSettings
@@ -81,7 +81,7 @@ async def app_factory() -> web.Application:
 
     exit_stack = AsyncExitStack()
     await exit_stack.enter_async_context(
-        setup_async_loggers(
+        async_loggers_lifespan(
             log_format_local_dev_enabled=app_settings.WEBSERVER_LOG_FORMAT_LOCAL_DEV_ENABLED,
             logger_filter_mapping=app_settings.WEBSERVER_LOG_FILTER_MAPPING,
             tracing_settings=app_settings.WEBSERVER_TRACING,