Skip to content

Commit 695d7ef

Browse files
Merge branch 'master' into create-case-in-fogbugz-via-email
2 parents f81aa73 + d9aef02 commit 695d7ef

File tree

12 files changed

+30
-11
lines changed

12 files changed

+30
-11
lines changed

api/specs/web-server/_conversations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async def list_conversations(
6969
): ...
7070

7171

72-
@router.put(
72+
@router.patch(
7373
"/conversations/{conversation_id}",
7474
response_model=Envelope[ConversationRestGet],
7575
)

packages/models-library/src/models_library/api_schemas_webserver/conversations.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from datetime import datetime
2-
from typing import Annotated, Self
2+
from typing import Annotated, Any, Self
33

44
from pydantic import Field
55

@@ -47,6 +47,7 @@ def from_domain_model(cls, domain: ConversationGetDB) -> Self:
4747

4848
class ConversationPatch(InputSchema):
4949
name: str | None = None
50+
extra_context: dict[str, Any] | None = None
5051

5152

5253
### CONVERSATION MESSAGES ---------------------------------------------------------------

packages/models-library/src/models_library/conversations.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ class ConversationMessageGetDB(BaseModel):
7070

7171
class ConversationPatchDB(BaseModel):
7272
name: ConversationName | None = None
73+
extra_context: dict[str, Any] | None = None
7374

7475

7576
class ConversationMessagePatchDB(BaseModel):

packages/service-library/src/servicelib/fastapi/client_session.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,25 @@
22

33
import httpx
44
from fastapi import FastAPI
5+
from servicelib.fastapi.tracing import setup_httpx_client_tracing
6+
from settings_library.tracing import TracingSettings
57

68

79
def setup_client_session(
810
app: FastAPI,
911
*,
1012
default_timeout: datetime.timedelta = datetime.timedelta(seconds=20),
11-
max_keepalive_connections: int = 20
13+
max_keepalive_connections: int = 20,
14+
tracing_settings: TracingSettings | None,
1215
) -> None:
1316
async def on_startup() -> None:
1417
session = httpx.AsyncClient(
1518
transport=httpx.AsyncHTTPTransport(http2=True),
1619
limits=httpx.Limits(max_keepalive_connections=max_keepalive_connections),
1720
timeout=default_timeout.total_seconds(),
1821
)
22+
if tracing_settings:
23+
setup_httpx_client_tracing(session)
1924
app.state.aiohttp_client_session = session
2025

2126
async def on_shutdown() -> None:

services/director/src/simcore_service_director/core/application.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def create_app(settings: ApplicationSettings) -> FastAPI:
5050
app,
5151
max_keepalive_connections=settings.DIRECTOR_REGISTRY_CLIENT_MAX_KEEPALIVE_CONNECTIONS,
5252
default_timeout=settings.DIRECTOR_REGISTRY_CLIENT_TIMEOUT,
53+
tracing_settings=settings.DIRECTOR_TRACING,
5354
)
5455
setup_registry(app)
5556

services/storage/src/simcore_service_storage/core/application.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def create_app(settings: ApplicationSettings) -> FastAPI: # noqa: C901
6969

7070
setup_db(app)
7171
setup_s3(app)
72-
setup_client_session(app)
72+
setup_client_session(app, tracing_settings=settings.STORAGE_TRACING)
7373

7474
if settings.STORAGE_CELERY and not settings.STORAGE_WORKER_MODE:
7575
setup_rabbitmq(app)

services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ paths:
571571
schema:
572572
$ref: '#/components/schemas/Page_ConversationRestGet_'
573573
/v0/conversations/{conversation_id}:
574-
put:
574+
patch:
575575
tags:
576576
- conversations
577577
summary: Update Conversation
@@ -10310,6 +10310,12 @@ components:
1031010310
- type: string
1031110311
- type: 'null'
1031210312
title: Name
10313+
extraContext:
10314+
anyOf:
10315+
- additionalProperties: true
10316+
type: object
10317+
- type: 'null'
10318+
title: Extracontext
1031310319
type: object
1031410320
title: ConversationPatch
1031510321
ConversationRestGet:

services/web/server/src/simcore_service_webserver/conversations/_controller/_conversations_rest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ async def get_conversation(request: web.Request):
163163
return envelope_json_response(data)
164164

165165

166-
@routes.put(
166+
@routes.patch(
167167
f"/{VTAG}/conversations/{{conversation_id}}",
168168
name="update_conversation",
169169
)
@@ -190,7 +190,7 @@ async def update_conversation(request: web.Request):
190190
app=request.app,
191191
project_id=None, # Support conversations don't use project_id
192192
conversation_id=path_params.conversation_id,
193-
updates=ConversationPatchDB(name=body_params.name),
193+
updates=ConversationPatchDB(**body_params.model_dump(exclude_unset=True)),
194194
)
195195

196196
data = ConversationRestGet.from_domain_model(conversation)

services/web/server/src/simcore_service_webserver/products/_models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
288288
"LOGIN_2FA_REQUIRED": False,
289289
},
290290
"group_id": 12345,
291+
"support_standard_group_id": 67890,
291292
"is_payment_enabled": False,
292293
},
293294
]

services/web/server/src/simcore_service_webserver/products/_repository.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
products.c.registration_email_template,
5454
products.c.max_open_studies_per_user,
5555
products.c.group_id,
56+
products.c.support_standard_group_id,
5657
]
5758

5859
assert {column.name for column in _PRODUCTS_COLUMNS}.issubset( # nosec

0 commit comments

Comments
 (0)