fixed broken tests

Author: Andrei Neagu

packages/models-library/src/models_library/api_schemas_long_running_tasks/tasks.py

@@ -27,12 +27,15 @@ class TaskBase(BaseModel):
 
     @field_validator("task_name", mode="before")
     @classmethod
-    def populate_task_name(cls, _, info):
-        task_name = ""
+    def populate_task_name(cls, task_id, info):
+        task_name = task_id
+
+        # attempt to solve the task name from the task_id
+        # if this is coming form a long_running_task
         task_id = info.data.get("task_id")
         if task_id:
             parts = task_id.split(".")
-            if len(parts) >= 1:
+            if len(parts) >= 2:
                 task_name = parts[1]
 
         return urllib.parse.unquote(task_name)

services/dynamic-sidecar/tests/unit/test_api_rest_containers_long_running_tasks.py

@@ -31,6 +31,7 @@
 from servicelib.fastapi.long_running_tasks.client import Client, periodic_task_result
 from servicelib.fastapi.long_running_tasks.client import setup as client_setup
 from servicelib.long_running_tasks.models import TaskId
+from servicelib.long_running_tasks.task import TaskRegistry
 from simcore_sdk.node_ports_common.exceptions import NodeNotFound
 from simcore_service_dynamic_sidecar._meta import API_VTAG
 from simcore_service_dynamic_sidecar.api.rest import containers_long_running_tasks
@@ -75,6 +76,8 @@ def mock_tasks(mocker: MockerFixture) -> Iterator[None]:
     async def _just_log_task(*args, **kwargs) -> None:
         print(f"Called mocked function with {args}, {kwargs}")
 
+    TaskRegistry.register(_just_log_task)
+
     # searching by name since all start with _task
     tasks_names = [
         x[0]
@@ -89,6 +92,8 @@ async def _just_log_task(*args, **kwargs) -> None:
 
     yield None
 
+    TaskRegistry.unregister(_just_log_task)
+
 
 @asynccontextmanager
 async def auto_remove_task(client: Client, task_id: TaskId) -> AsyncIterator[None]: