@@ -1890,7 +1890,7 @@ jobs:
18901890 with :
18911891 python-version : ${{ matrix.python }}
18921892 cache-dependency-glob : " **/e2e/requirements/requirements.txt"
1893- - uses : actions/setup-node@v4.1 .0
1893+ - uses : actions/setup-node@v4.4 .0
18941894 with :
18951895 node-version : ${{ matrix.node }}
18961896 cache : " npm"
@@ -1903,20 +1903,27 @@ jobs:
19031903 run : ./ci/github/system-testing/e2e.bash install
19041904 - name : test
19051905 run : ./ci/github/system-testing/e2e.bash test
1906+ - name : wait before dumping logs
1907+ if : ${{ failure() }}
1908+ run : sleep 5
19061909 - name : dump docker logs
1910+ if : ${{ failure() }}
19071911 id : docker_logs_dump
19081912 run : ./ci/github/system-testing/e2e.bash dump_docker_logs
19091913 - name : upload docker logs
1914+ if : ${{ failure() }}
19101915 uses : actions/upload-artifact@v4
19111916 with :
19121917 name : ${{ github.job }}_docker_logs
19131918 path : ./tests/e2e/test_failures
19141919 - name : upload screenshots
1920+ if : ${{ failure() }}
19151921 uses : actions/upload-artifact@v4
19161922 with :
19171923 name : ${{ github.job }}_screenshots
19181924 path : tests/e2e/screenshots
19191925 - name : upload e2e logs
1926+ if : ${{ failure() }}
19201927 uses : actions/upload-artifact@v4
19211928 with :
19221929 name : ${{ github.job }}_logs
@@ -1955,15 +1962,21 @@ jobs:
19551962 - name : test
19561963 run : |
19571964 ./ci/github/system-testing/e2e-playwright.bash test
1965+ - name : wait before dumping logs
1966+ if : ${{ failure() }}
1967+ run : sleep 5
19581968 - name : dump docker logs
1969+ if : ${{ failure() }}
19591970 id : docker_logs_dump
19601971 run : ./ci/github/system-testing/e2e-playwright.bash dump_docker_logs
19611972 - name : upload docker logs
1973+ if : ${{ failure() }}
19621974 uses : actions/upload-artifact@v4
19631975 with :
19641976 name : ${{ github.job }}_docker_logs
19651977 path : ./tests/e2e-playwright/test_failures
19661978 - name : upload tracing if failed
1979+ if : ${{ failure() }}
19671980 uses : actions/upload-artifact@v4
19681981 with :
19691982 name : ${{ github.job }}_tracing
0 commit comments