Skip to content

Commit 6d7ed3c

Browse files
committed
fixed compute node resources
1 parent 6d56404 commit 6d7ed3c

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

services/autoscaling/src/simcore_service_autoscaling/utils/utils_docker.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -358,13 +358,11 @@ async def compute_node_used_resources(
358358
and task.spec.resources
359359
and task.spec.resources.reservations
360360
):
361-
task_reservations = task.spec.resources.reservations.model_dump(
362-
exclude_none=True
363-
)
364361
cluster_resources_counter.update(
365362
{
366-
"ram": task_reservations.get("MemoryBytes", 0),
367-
"cpus": task_reservations.get("NanoCPUs", 0) / _NANO_CPU,
363+
"ram": task.spec.resources.reservations.memory_bytes or 0,
364+
"cpus": (task.spec.resources.reservations.nano_cp_us or 0)
365+
/ _NANO_CPU,
368366
}
369367
)
370368
return Resources.model_validate(dict(cluster_resources_counter))

services/autoscaling/tests/unit/test_utils_docker.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -436,29 +436,24 @@ async def test_pending_service_task_with_insufficient_resources_properly_sorts_t
436436

437437
assert len(pending_tasks) == len(services)
438438
# check sorting is done by creation date
439-
last_date = datetime.datetime.now(datetime.timezone.utc) - datetime.timedelta(
440-
days=1
441-
)
439+
last_date = datetime.datetime.now(datetime.UTC) - datetime.timedelta(days=1)
442440
for task in pending_tasks:
443441
assert task.created_at # NOTE: in this case they are but they might be None
444-
assert (
445-
to_datetime(task.created_at).replace(tzinfo=datetime.timezone.utc)
446-
> last_date
447-
)
448-
last_date = to_datetime(task.created_at).replace(tzinfo=datetime.timezone.utc)
442+
assert to_datetime(task.created_at).replace(tzinfo=datetime.UTC) > last_date
443+
last_date = to_datetime(task.created_at).replace(tzinfo=datetime.UTC)
449444

450445

451446
def test_safe_sort_key_callback():
452447
tasks_with_faulty_timestamp = [
453-
Task(ID=n, CreatedAt=value) # type: ignore
448+
Task(ID=f"{n}", CreatedAt=value)
454449
for n, value in enumerate(
455450
[
456451
# SEE test_to_datetime_conversion_known_errors
457452
None,
458453
"2023-03-15 09:20:58.123456",
459454
"2023-03-15T09:20:58.123456",
460455
"2023-03-15T09:20:58.123456Z",
461-
f"{datetime.datetime.now(datetime.timezone.utc)}",
456+
f"{datetime.datetime.now(datetime.UTC)}",
462457
"corrupted string",
463458
]
464459
)

0 commit comments

Comments
 (0)