@GitHK review: more stuff

Author: sanderegg

services/director/src/simcore_service_director/constants.py

@@ -20,9 +20,4 @@
 
 DIRECTOR_SIMCORE_SERVICES_PREFIX: Final[str] = "simcore/services"
 
-
-# TO remove
-# used when in devel mode vs release mode
-NODE_SCHEMA_LOCATION: Final[str] = f"{API_ROOT}/v0/schemas/node-meta-v0.0.1.json"
-
 DATETIME_FORMAT: Final[str] = "%Y-%m-%dT%H:%M:%S.%f"

services/director/src/simcore_service_director/core/application.py

@@ -21,7 +21,7 @@
 _LOG_LEVEL_STEP = logging.CRITICAL - logging.ERROR
 _NOISY_LOGGERS: Final[tuple[str]] = ("werkzeug",)
 
-logger = logging.getLogger(__name__)
+_logger = logging.getLogger(__name__)
 
 
 def create_app(settings: ApplicationSettings) -> FastAPI:
@@ -32,7 +32,7 @@ def create_app(settings: ApplicationSettings) -> FastAPI:
     for name in _NOISY_LOGGERS:
         logging.getLogger(name).setLevel(quiet_level)
 
-    logger.info("app settings: %s", settings.json(indent=1))
+    _logger.info("app settings: %s", settings.json(indent=1))
 
     app = FastAPI(
         debug=settings.DIRECTOR_DEBUG,

services/director/tests/unit/api/test_rest_running_interactive_services.py

@@ -25,30 +25,6 @@ def _assert_response_and_unwrap_envelope(got: httpx.Response):
     return body.get("data"), body.get("error")
 
 
-@pytest.mark.skip(
-    reason="docker_swarm fixture is a session fixture making it bad running together with other tests that require a swarm"
-)
-async def test_running_services_post_and_delete_no_swarm(
-    configure_swarm_stack_name: EnvVarsDict,
-    client: httpx.AsyncClient,
-    push_services,
-    user_id: UserID,
-    project_id: ProjectID,
-    api_version_prefix: str,
-):
-    params = {
-        "user_id": "None",
-        "project_id": "None",
-        "service_uuid": "sdlfkj4",
-        "service_key": "simcore/services/comp/some-key",
-    }
-    resp = await client.post(
-        f"/{api_version_prefix}/running_interactive_services", params=params
-    )
-    data = resp.json()
-    assert resp.status_code == 500, data
-
-
 @pytest.mark.parametrize(
     "save_state, expected_save_state_call", [(True, True), (False, False), (None, True)]
 )