add some docs

sanderegg · sanderegg · commit 70bac275ac81 · 2025-09-23T17:16:02.000+02:00
diff --git a/packages/service-library/src/servicelib/redis/_semaphore.py b/packages/service-library/src/servicelib/redis/_semaphore.py
@@ -476,6 +476,8 @@ async def _periodic_reacquisition(
             )
             await auto_reacquisition_started.wait()
             try:
+                # NOTE: this try/finally ensures that cancellation_event is set when we exit the context
+                # even in case of exceptions
                 yield semaphore
             finally:
                 cancellation_event.set()  # NOTE: this ensure cancellation is effective

Original file line number	Diff line number	Diff line change
`@@ -476,6 +476,8 @@ async def _periodic_reacquisition(`
`476`	`476`	`)`
`477`	`477`	`await auto_reacquisition_started.wait()`
`478`	`478`	`try:`
	`479`	`+ # NOTE: this try/finally ensures that cancellation_event is set when we exit the context`
	`480`	`+ # even in case of exceptions`
`479`	`481`	`yield semaphore`
`480`	`482`	`finally:`
`481`	`483`	`cancellation_event.set() # NOTE: this ensure cancellation is effective`