refactor

Author: sanderegg

packages/service-library/tests/redis/test_clients_manager.py

@@ -1,10 +1,23 @@
+# pylint:disable=unused-variable
+# pylint:disable=unused-argument
+# pylint:disable=redefined-outer-name
+# pylint:disable=protected-access
+
 from servicelib.redis._clients_manager import RedisClientsManager
 from servicelib.redis._models import RedisManagerDBConfig
 from settings_library.redis import RedisDatabase, RedisSettings
 
+pytest_simcore_core_services_selection = [
+    "redis",
+]
+pytest_simcore_ops_services_selection = [
+    "redis-commander",
+]
+
 
 async def test_redis_client_sdks_manager(
-    mock_redis_socket_timeout: None, redis_service: RedisSettings
+    mock_redis_socket_timeout: None,
+    redis_service: RedisSettings,
 ):
     all_redis_configs: set[RedisManagerDBConfig] = {
         RedisManagerDBConfig(database=db) for db in RedisDatabase

packages/service-library/tests/redis/test_decorators.py

@@ -1,4 +1,8 @@
+# pylint:disable=unused-variable
+# pylint:disable=unused-argument
 # pylint:disable=redefined-outer-name
+# pylint:disable=protected-access
+
 
 import asyncio
 import datetime
@@ -68,6 +72,15 @@ def sleep_duration(faker: Faker) -> float:
     return faker.pyfloat(positive=True, min_value=0.2, max_value=0.8)
 
 
+async def test_exclusive_with_empty_lock_key_raises(redis_client_sdk: RedisClientSDK):
+    @exclusive(redis_client_sdk, lock_key="")
+    async def _():
+        pass
+
+    with pytest.raises(ValueError, match="lock_key cannot be empty"):
+        await _()
+
+
 async def test_exclusive_decorator(
     get_redis_client_sdk: Callable[
         [RedisDatabase], AbstractAsyncContextManager[RedisClientSDK]