refactor

Author: Andrei Neagu

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_core.py

@@ -24,7 +24,7 @@
     safe_event,
     set_unexpected_opration_state,
     start_and_mark_as_started,
-    start_steps_and_get_count,
+    start_steps_which_were_not_started,
 )
 from ._deferred_runner import DeferredRunner
 from ._dependencies import enqueue_schedule_event
@@ -288,12 +288,11 @@ async def _on_schedule_event(self, schedule_id: ScheduleId) -> None:
         )
 
         # 1) ensure all steps in the group are started
-        started_steps_couunt = await start_steps_and_get_count(
+        if await start_steps_which_were_not_started(
             group_step_proxies,
             is_creating=is_creating,
             group_step_count=len(step_group),
-        )
-        if started_steps_couunt > 0:
+        ):
             # since steps were started, we wait for next event to check their status
             return
 

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_core_utils.py

@@ -165,12 +165,14 @@ async def _get_steps_to_start(
     return [proxy for was_started, proxy in result if was_started is False]
 
 
-async def start_steps_and_get_count(
+async def start_steps_which_were_not_started(
     group_step_proxies: dict[StepName, StepStoreProxy],
     *,
     is_creating: bool,
     group_step_count: NonNegativeInt,
-) -> NonNegativeInt:
+) -> bool:
+    """retruns True if any step was started"""
+    started_count: NonNegativeInt = 0
     if to_start_step_proxies := await _get_steps_to_start(group_step_proxies.values()):
         steps_to_start_names = [
             step_proxy.step_name for step_proxy in to_start_step_proxies
@@ -191,8 +193,8 @@ async def start_steps_and_get_count(
                 ),
                 limit=PARALLEL_STATUS_REQUESTS,
             )
-        return len(to_start_step_proxies)
-    return 0
+        started_count = len(to_start_step_proxies)
+    return started_count > 0
 
 
 async def cleanup_after_finishing(