fixes

Author: pcrespov

packages/postgres-database/src/simcore_postgres_database/utils_users.py

@@ -307,8 +307,9 @@ async def is_email_used(
             if registered:
                 return True
 
+            # Check if email exists in pre-registration, regardless of user_id status
             pre_registered = await conn.scalar(
-                sa.select(users_pre_registration_details.c.user_id).where(
+                sa.select(users_pre_registration_details.c.id).where(
                     users_pre_registration_details.c.pre_email == email
                 )
             )

packages/service-library/tests/aiohttp/test_rest_middlewares.py

@@ -361,13 +361,13 @@ async def test_exception_in_handler_returns_500(
 ):
     """Test that exceptions in the handler functions are caught and return 500."""
 
-    # Mock _handle_http_successful to raise an exception
+    # Mock _handle_aiohttp_web_http_successful to raise an exception
     def mocked_handler(*args, **kwargs):
         msg = "Simulated error in handler"
         raise ValueError(msg)
 
     mocker.patch(
-        "servicelib.aiohttp.rest_middlewares._handle_http_successful",
+        "servicelib.aiohttp.rest_middlewares._handle_aiohttp_web_http_successful",
         side_effect=mocked_handler,
     )
 

services/web/server/src/simcore_service_webserver/login/_auth_service.py

@@ -121,7 +121,7 @@ async def check_authorized_user_credentials(
 
     user = check_not_null_user(user)
 
-    _login_service.validate_user_status(
+    _login_service.validate_user_access(
         user_status=user["status"],
         user_role=user["role"],
         support_email=product.support_email,

services/web/server/src/simcore_service_webserver/login/_controller/rest/change.py

@@ -22,7 +22,7 @@
 from ..._login_service import (
     ACTIVE,
     CHANGE_EMAIL,
-    validate_user_status,
+    validate_user_access,
 )
 from ...constants import (
     MSG_CANT_SEND_MAIL,
@@ -136,7 +136,7 @@ def _get_error_context(
 
         # CHECK user state
         try:
-            validate_user_status(
+            validate_user_access(
                 user_status=user["status"],
                 user_role=user["role"],
                 support_email=product.support_email,

services/web/server/src/simcore_service_webserver/login/_login_service.py

@@ -39,7 +39,7 @@ def _to_names(enum_cls, names) -> list[str]:
 )
 
 
-def validate_user_status(*, user_status: str, user_role: str, support_email: str):
+def validate_user_access(*, user_status: str, user_role: str, support_email: str):
     """
 
     Raises: