Skip to content

Commit 7318dc1

Browse files
committed
add deprecation warnings to all listing endpoints
1 parent fc9245f commit 7318dc1

File tree

3 files changed

+40
-12
lines changed

3 files changed

+40
-12
lines changed

services/api-server/src/simcore_service_api_server/api/routes/files.py

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@
2929
get_upload_links_from_s3,
3030
)
3131
from simcore_sdk.node_ports_common.filemanager import upload_path as storage_upload_path
32+
from simcore_service_api_server.api.routes._constants import (
33+
FMSG_CHANGELOG_ADDED_IN_VERSION,
34+
FMSG_CHANGELOG_REMOVED_IN_VERSION_FORMAT,
35+
create_route_description,
36+
)
3237
from starlette.datastructures import URL
3338
from starlette.responses import RedirectResponse
3439

@@ -132,7 +137,20 @@ async def _create_domain_file(
132137
return file
133138

134139

135-
@router.get("", response_model=list[OutputFile], responses=_FILE_STATUS_CODES)
140+
@router.get(
141+
"",
142+
response_model=list[OutputFile],
143+
responses=_FILE_STATUS_CODES,
144+
description=create_route_description(
145+
base="Lists all files stored in the system",
146+
deprecated=True,
147+
alternative="GET /v0/files/page",
148+
changelog=[
149+
FMSG_CHANGELOG_ADDED_IN_VERSION.format("0.5"),
150+
FMSG_CHANGELOG_REMOVED_IN_VERSION_FORMAT.format("0.7"),
151+
],
152+
),
153+
)
136154
async def list_files(
137155
storage_client: Annotated[StorageApi, Depends(get_api_client(StorageApi))],
138156
user_id: Annotated[int, Depends(get_current_user_id)],

services/api-server/src/simcore_service_api_server/api/routes/solvers.py

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@
2020
from ..dependencies.services import get_api_client
2121
from ..dependencies.webserver_http import AuthSession, get_webserver_session
2222
from ._common import API_SERVER_DEV_FEATURES_ENABLED
23-
from ._constants import FMSG_CHANGELOG_NEW_IN_VERSION
23+
from ._constants import (
24+
FMSG_CHANGELOG_NEW_IN_VERSION,
25+
FMSG_CHANGELOG_REMOVED_IN_VERSION_FORMAT,
26+
create_route_description,
27+
)
2428

2529
_logger = logging.getLogger(__name__)
2630

@@ -44,17 +48,27 @@
4448
# Would be nice to have /solvers/foo/releases/latest or solvers/foo/releases/3 , similar to docker tagging
4549

4650

47-
@router.get("", response_model=list[Solver], responses=_SOLVER_STATUS_CODES)
51+
@router.get(
52+
"",
53+
response_model=list[Solver],
54+
responses=_SOLVER_STATUS_CODES,
55+
description=create_route_description(
56+
base="Lists all available solvers (latest version)",
57+
deprecated=True,
58+
alternative="GET /v0/solvers/page",
59+
changelog=[
60+
FMSG_CHANGELOG_NEW_IN_VERSION.format("0.5.0"),
61+
FMSG_CHANGELOG_REMOVED_IN_VERSION_FORMAT.format("0.7"),
62+
],
63+
),
64+
)
4865
async def list_solvers(
4966
user_id: Annotated[int, Depends(get_current_user_id)],
5067
catalog_client: Annotated[CatalogApi, Depends(get_api_client(CatalogApi))],
5168
url_for: Annotated[Callable, Depends(get_reverse_url_mapper)],
5269
product_name: Annotated[str, Depends(get_product_name)],
5370
):
54-
"""Lists all available solvers (latest version)
55-
56-
SEE get_solvers_page for paginated version of this function
57-
"""
71+
"""Lists all available solvers (latest version)"""
5872
solvers: list[Solver] = await catalog_client.list_latest_releases(
5973
user_id=user_id, product_name=product_name
6074
)

services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,7 @@ async def list_jobs(
144144
url_for: Annotated[Callable, Depends(get_reverse_url_mapper)],
145145
product_name: Annotated[str, Depends(get_product_name)],
146146
):
147-
"""List of jobs in a specific released solver (limited to 20 jobs)
148-
149-
- DEPRECATION: This implementation and returned values are deprecated and the will be replaced by that of get_jobs_page
150-
- SEE `get_jobs_page` for paginated version of this function
151-
"""
147+
"""List of jobs in a specific released solver (limited to 20 jobs)"""
152148

153149
solver = await solver_service.get_solver(
154150
user_id=user_id,

0 commit comments

Comments
 (0)