drafted tests

Author: pcrespov

services/web/server/src/simcore_service_webserver/groups/_groups_repository.py

@@ -490,7 +490,7 @@ async def list_users_in_group(
     group_id: GroupID,
 ) -> list[GroupMember]:
     async with pass_or_acquire_connection(get_asyncpg_engine(app), connection) as conn:
-        # first check if the group exists
+        # GET GROUP & caller access
         result = await conn.execute(
             sa.select(
                 *_GROUP_COLUMNS,
@@ -510,23 +510,30 @@ async def list_users_in_group(
         if not group_row:
             raise GroupNotFoundError(gid=group_id)
 
+        # Drop access-rights if primary group
         if group_row.type != GroupType.PRIMARY:
             _check_group_permissions(
                 group_row, caller_id=user_id, group_id=group_id, permission="read"
             )
-
-        # now get the list
-        query = (
-            sa.select(
+            query = sa.select(
                 *_group_user_cols(user_id),
                 user_to_groups.c.access_rights,
             )
-            .select_from(users.join(user_to_groups, isouter=True))
-            .where(user_to_groups.c.gid == group_id)
+        else:
+            query = sa.select(
+                *_group_user_cols(user_id),
+            )
+
+        # GET users
+        query = query.select_from(users.join(user_to_groups, isouter=True)).where(
+            user_to_groups.c.gid == group_id
         )
 
         result = await conn.stream(query)
-        return [GroupMember.model_validate(row) async for row in result]
+        return [
+            GroupMember.model_validate(row, from_attributes=True)
+            async for row in result
+        ]
 
 
 async def get_user_in_group(

services/web/server/tests/unit/with_dbs/03/test_users.py

@@ -159,22 +159,30 @@ async def test_get_and_search_public_users(
 
         # GET user by primary GID
         url = client.app.router["get_all_group_users"].url_for(
-            gid=f"{public_user['id']}"
+            gid=f"{public_user['primary_gid']}"
         )
         resp = await client.get(f"{url}")
         data, _ = await assert_status(resp, status.HTTP_200_OK)
 
-        user = GroupUserGet.model_validate(data)
-        assert user.id == public_user["id"]
+        users = TypeAdapter(list[GroupUserGet]).validate_python(data)
+        assert len(users) == 1
+        assert users[0].id == public_user["id"]
+        assert users[0].user_name == public_user["name"]
+        assert users[0].first_name == public_user.get("first_name")
+        assert users[0].last_name == public_user.get("last_name")
 
         url = client.app.router["get_all_group_users"].url_for(
-            gid=f"{private_user['id']}"
+            gid=f"{private_user['primary_gid']}"
         )
         resp = await client.get(f"{url}")
         data, _ = await assert_status(resp, status.HTTP_200_OK)
 
-        user = GroupUserGet.model_validate(data)
-        assert user.id == private_user["id"]
+        users = TypeAdapter(list[GroupUserGet]).validate_python(data)
+        assert len(users) == 1
+        assert users[0].id == private_user["id"]
+        assert users[0].user_name == private_user["name"]
+        assert users[0].first_name is None
+        assert users[0].last_name is None
 
 
 @pytest.mark.parametrize(