🐛 [Frontend] Fix: Don't let editors delete my project (#8703)

Author: odeimaiz

services/static-webserver/client/source/class/osparc/auth/ui/RequestAccount.js

@@ -131,8 +131,7 @@ qx.Class.define("osparc.auth.ui.RequestAccount", {
             country.setSelection([countryFound])
           }
         })
-        .catch(err => {
-          console.error(err);
+        .catch(() => {
           const emptyItem = new qx.ui.form.ListItem("", null, "");
           country.add(emptyItem);
           country.setSelection([emptyItem]);

services/static-webserver/client/source/class/osparc/dashboard/CardBase.js

@@ -46,7 +46,7 @@ qx.Class.define("osparc.dashboard.CardBase", {
     "updateHypertool": "qx.event.type.Data",
     "publishTemplate": "qx.event.type.Data",
     "tagClicked": "qx.event.type.Data",
-    "emptyStudyClicked": "qx.event.type.Data"
+    "emptyProjectIconClicked": "qx.event.type.Data",
   },
 
   statics: {
@@ -1052,9 +1052,9 @@ qx.Class.define("osparc.dashboard.CardBase", {
         if (moveToButton) {
           moveToButton.setEnabled(osparc.study.Utils.canMoveTo(resourceData));
         }
-        const trashButton = menuButtons.find(menuBtn => "trashButton" in menuBtn);
-        if (trashButton) {
-          trashButton.setEnabled(osparc.study.Utils.canBeDeleted(resourceData));
+        const deleteButton = menuButtons.find(menuBtn => "deleteButton" in menuBtn);
+        if (deleteButton) {
+          deleteButton.setEnabled(osparc.study.Utils.canBeDeleted(resourceData));
         }
       }
     },
@@ -1167,7 +1167,7 @@ qx.Class.define("osparc.dashboard.CardBase", {
       });
       control.addListener("tap", e => {
         e.stopPropagation();
-        this.fireDataEvent("emptyStudyClicked", this.getUuid());
+        this.fireDataEvent("emptyProjectIconClicked", this.getUuid());
       }, this);
       return control;
     },

services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js

@@ -52,8 +52,8 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
     this.__centerLayout = new qx.ui.container.Composite(new qx.ui.layout.VBox(15));
     mainLayoutWithSideSpacers.add(this.__centerLayout);
 
-    const rightColum = new qx.ui.container.Composite(new qx.ui.layout.VBox());
-    mainLayoutWithSideSpacers.add(rightColum, {
+    const rightColumn = new qx.ui.container.Composite(new qx.ui.layout.VBox());
+    mainLayoutWithSideSpacers.add(rightColumn, {
       flex: 1
     });
 
@@ -70,7 +70,7 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       }
 
       const compactVersion = w < this.__centerLayout.getMinWidth() + leftColumnWidth + emptyColumnMinWidth;
-      rightColum.setVisibility(compactVersion ? "excluded" : "visible");
+      rightColumn.setVisibility(compactVersion ? "excluded" : "visible");
     };
     fitResourceCards();
     window.addEventListener("resize", () => fitResourceCards());
@@ -329,7 +329,7 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       resourcesContainer.addListener("updateHypertool", e => this._updateHypertoolData(e.getData()));
       resourcesContainer.addListener("publishTemplate", e => this.fireDataEvent("publishTemplate", e.getData()));
       resourcesContainer.addListener("tagClicked", e => this._searchBarFilter.addTagActiveFilter(e.getData()));
-      resourcesContainer.addListener("emptyStudyClicked", e => this._deleteResourceRequested(e.getData()));
+      resourcesContainer.addListener("emptyProjectIconClicked", e => this._emptyProjectIconClicked(e.getData()));
       resourcesContainer.addListener("folderUpdated", e => this._folderUpdated(e.getData()));
       resourcesContainer.addListener("moveFolderToRequested", e => this._moveFolderToRequested(e.getData()));
       resourcesContainer.addListener("trashFolderRequested", e => this._trashFolderRequested(e.getData()));
@@ -889,7 +889,7 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       return;
     },
 
-    _deleteResourceRequested: function(resourceId) {
+    _emptyProjectIconClicked: function(resourceId) {
       throw new Error("Abstract method called!");
     },
 

services/static-webserver/client/source/class/osparc/dashboard/ResourceContainerManager.js

@@ -84,7 +84,7 @@ qx.Class.define("osparc.dashboard.ResourceContainerManager", {
     "updateHypertool": "qx.event.type.Data",
     "publishTemplate": "qx.event.type.Data",
     "tagClicked": "qx.event.type.Data",
-    "emptyStudyClicked": "qx.event.type.Data",
+    "emptyProjectIconClicked": "qx.event.type.Data",
     "changeSelection": "qx.event.type.Data",
     "changeVisibility": "qx.event.type.Data",
     "folderSelected": "qx.event.type.Data",
@@ -351,7 +351,7 @@ qx.Class.define("osparc.dashboard.ResourceContainerManager", {
         "updateHypertool",
         "publishTemplate",
         "tagClicked",
-        "emptyStudyClicked"
+        "emptyProjectIconClicked"
       ].forEach(eName => card.addListener(eName, e => this.fireDataEvent(eName, e.getData())));
       return card;
     },