preparing for the finish

Author: sanderegg

services/autoscaling/src/simcore_service_autoscaling/core/errors.py

@@ -43,4 +43,6 @@ class DaskNoWorkersError(AutoscalingRuntimeError):
 
 
 class DaskWorkerNotFoundError(AutoscalingRuntimeError):
-    msg_template: str = "Dask worker running on {worker_host} is not registered to scheduler in {url}, it is not found!"
+    msg_template: str = (
+        "Dask worker running on {worker_host} is not registered to scheduler in {url}, it is not found!"
+    )

services/autoscaling/src/simcore_service_autoscaling/modules/cluster_scaling/_auto_scaling_core.py

@@ -694,11 +694,14 @@ async def _find_needed_instances(
             try:
                 # check if exact instance type is needed first
                 if task_required_ec2:
+                    # TODO: we need to adjust the available types to cope with the threads resource
+                    # and also with the dask resource reduction!
                     defined_ec2 = find_selected_instance_type_for_task(
                         task_required_ec2,
                         available_ec2_types,
                         task,
                         task_required_resources,
+                        auto_scaling_mode,
                     )
                     needed_new_instance_types_for_tasks.append(
                         AssignedTasksToInstanceType(
@@ -709,6 +712,8 @@ async def _find_needed_instances(
                         )
                     )
                 else:
+                    # TODO: same here. so probably the best is to adjust prior to calling
+                    # it is differnet from dynamic/computational
                     # we go for best fitting type
                     best_ec2_instance = utils_ec2.find_best_fitting_ec2_instance(
                         available_ec2_types,