Skip to content

Commit 75964f9

Browse files
committed
fixes testss
1 parent 567075e commit 75964f9

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

services/web/server/src/simcore_service_webserver/workspaces/_exceptions_handlers.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
HttpErrorInfo,
88
create_exception_handlers_decorator,
99
)
10-
from ..projects.exceptions import ProjectRunningConflictError, ProjectStoppingError
10+
from ..projects.exceptions import (
11+
BaseProjectError,
12+
ProjectRunningConflictError,
13+
ProjectStoppingError,
14+
)
1115
from .errors import (
1216
WorkspaceAccessForbiddenError,
1317
WorkspaceGroupNotFoundError,
@@ -44,6 +48,6 @@
4448

4549

4650
handle_plugin_requests_exceptions = create_exception_handlers_decorator(
47-
exceptions_catch=(WorkspacesValueError),
51+
exceptions_catch=(BaseProjectError, WorkspacesValueError),
4852
exc_to_status_map=_TO_HTTP_ERROR_MAP,
4953
)

services/web/server/src/simcore_service_webserver/workspaces/_trash_api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async def trash_workspace(
5959
)
6060

6161
# IMPLICIT trash
62-
child_folders: list[FolderID] = [] # TODO: find children
62+
child_folders: list[FolderID] = [] # TODO: find children. Check with MD
6363

6464
for folder_id in child_folders:
6565
await trash_folder(
@@ -70,7 +70,7 @@ async def trash_workspace(
7070
force_stop_first=force_stop_first,
7171
)
7272

73-
child_projects: list[ProjectID] = [] # TODO: find children
73+
child_projects: list[ProjectID] = [] # TODO: find children. Check with MD
7474

7575
for project_id in child_projects:
7676
await trash_project(
@@ -104,7 +104,7 @@ async def untrash_workspace(
104104
updates=WorkspaceUpdateDB(trashed=None, trashed_by=None),
105105
)
106106

107-
child_folders: list[FolderID] = [] # TODO: find children
107+
child_folders: list[FolderID] = [] # TODO: find children. Check with MD
108108

109109
for folder_id in child_folders:
110110
await untrash_folder(
@@ -114,7 +114,7 @@ async def untrash_workspace(
114114
folder_id=folder_id,
115115
)
116116

117-
child_projects: list[ProjectID] = [] # TODO: find children
117+
child_projects: list[ProjectID] = [] # TODO: find children. Check with MD
118118

119119
for project_id in child_projects:
120120
await untrash_project(

0 commit comments

Comments
 (0)