Skip to content

Commit 7697eab

Browse files
author
Andrei Neagu
committed
fixed tests
1 parent 0c5ac7e commit 7697eab

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

services/storage/src/simcore_service_storage/settings.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
field_validator,
99
model_validator,
1010
)
11-
from pydantic_settings import SettingsConfigDict
1211
from servicelib.logging_utils_filtering import LoggerName, MessageSubstring
1312
from settings_library.base import BaseCustomSettings
1413
from settings_library.basic_types import LogLevel, PortInt
@@ -112,5 +111,3 @@ def ensure_settings_consistency(self) -> Self:
112111
)
113112
raise ValueError(msg)
114113
return self
115-
116-
model_config = SettingsConfigDict(extra="allow")

services/storage/tests/unit/test_cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_cli_settings_as_json(
2929
assert result.exit_code == os.EX_OK, result
3030
# reuse resulting json to build settings
3131
settings: dict = json.loads(result.stdout)
32-
assert Settings.model_validate(settings)
32+
assert Settings(settings)
3333

3434

3535
def test_cli_settings_env_file(
@@ -46,4 +46,4 @@ def test_cli_settings_env_file(
4646
with contextlib.suppress(json.decoder.JSONDecodeError):
4747
settings[key] = json.loads(str(value))
4848

49-
assert Settings.model_validate(settings)
49+
assert Settings(settings)

0 commit comments

Comments
 (0)