fixed tracing setup

Author: Andrei Neagu

packages/service-library/src/servicelib/fastapi/tracing.py

@@ -3,10 +3,8 @@
 """
 
 import logging
-from collections.abc import AsyncIterator
 
 from fastapi import FastAPI
-from fastapi_lifespan_manager import State
 from httpx import AsyncClient, Client
 from opentelemetry import trace
 from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
@@ -17,7 +15,6 @@
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import BatchSpanProcessor
-from servicelib.fastapi.lifespan_utils import LifespanGenerator
 from servicelib.logging_utils import log_context
 from settings_library.tracing import TracingSettings
 from yarl import URL
@@ -134,14 +131,10 @@ def setup_tracing(
             RequestsInstrumentor().instrument()
 
 
-def get_lifespan_tracing(
-    tracing_settings: TracingSettings, service_name: str
-) -> LifespanGenerator:
-    async def _(app: FastAPI) -> AsyncIterator[State]:
-        setup_tracing(app, tracing_settings, service_name)
-        yield {}
-
-    return _
+def initialize_tracing(
+    app: FastAPI, tracing_settings: TracingSettings, service_name: str
+):
+    setup_tracing(app, tracing_settings, service_name)
 
 
 def setup_httpx_client_tracing(client: AsyncClient | Client):

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/application.py

@@ -9,7 +9,7 @@
     initialize_prometheus_instrumentation,
     lifespan_prometheus_instrumentation,
 )
-from servicelib.fastapi.tracing import get_lifespan_tracing
+from servicelib.fastapi.tracing import initialize_tracing
 
 from .._meta import (
     API_VERSION,
@@ -59,11 +59,6 @@ def create_app(settings: ApplicationSettings | None = None) -> FastAPI:
     if app_settings.DYNAMIC_SCHEDULER_PROMETHEUS_INSTRUMENTATION_ENABLED:
         lifespans.append(lifespan_prometheus_instrumentation)
 
-    if app_settings.DYNAMIC_SCHEDULER_TRACING:
-        lifespans.append(
-            get_lifespan_tracing(app_settings.DYNAMIC_SCHEDULER_TRACING, APP_NAME)
-        )
-
     app = FastAPI(
         title=f"{PROJECT_NAME} web API",
         description=SUMMARY,
@@ -87,6 +82,9 @@ def create_app(settings: ApplicationSettings | None = None) -> FastAPI:
 
     initialize_frontend(app)
 
+    if app_settings.DYNAMIC_SCHEDULER_TRACING:
+        initialize_tracing(app, app_settings.DYNAMIC_SCHEDULER_TRACING, APP_NAME)
+
     if app_settings.DYNAMIC_SCHEDULER_PROFILING:
         initialize_profiler(app)