moved parametrization to fixture

Author: Andrei Neagu

services/dynamic-scheduler/tests/unit/api_frontend/_routes_internal_scheduler/conftest.py

@@ -0,0 +1,6 @@
+import pytest
+
+
+@pytest.fixture
+def use_internal_scheduler() -> bool:
+    return True

services/dynamic-scheduler/tests/unit/api_frontend/_routes_internal_scheduler/test__index_.py

@@ -1,7 +1,6 @@
 # pylint:disable=redefined-outer-name
 # pylint:disable=unused-argument
 
-import pytest
 from helpers import assert_contains_text
 from playwright.async_api import Page
 from simcore_service_dynamic_scheduler.api.frontend._utils import get_settings
@@ -17,7 +16,6 @@
 ]
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [True])
 async def test_placeholder_index(
     app_runner: None, async_page: Page, server_host_port: str
 ):

services/dynamic-scheduler/tests/unit/api_frontend/conftest.py

@@ -36,7 +36,7 @@ def disable_status_monitor_background_task(mocker: MockerFixture) -> None:
 def app_environment(
     monkeypatch: pytest.MonkeyPatch,
     app_environment: EnvVarsDict,
-    use_internal_scheduler: bool,  # has to be added to every test
+    use_internal_scheduler: bool,
     postgres_db: sa.engine.Engine,
     postgres_host_config: PostgresTestConfig,
     disable_status_monitor_background_task: None,

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/conftest.py

@@ -11,6 +11,11 @@
 )
 
 
+@pytest.fixture
+def use_internal_scheduler() -> bool:
+    return False
+
+
 @pytest.fixture
 def mock_stop_dynamic_service(mocker: MockerFixture) -> AsyncMock:
     async_mock = AsyncMock()

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__index.py

@@ -42,7 +42,6 @@
 ]
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_index_with_elements(
     app_runner: None,
     async_page: Page,
@@ -70,7 +69,6 @@ async def test_index_with_elements(
     await assert_contains_text(async_page, "Details", instances=2)
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [False])
 @pytest.mark.parametrize(
     "service_status",
     [

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__service.py

@@ -38,7 +38,6 @@
 ]
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_service_details_no_status_present(
     app_runner: None,
     async_page: Page,
@@ -67,7 +66,6 @@ async def test_service_details_no_status_present(
     await assert_contains_text(async_page, "Remove from tracking", instances=1)
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_service_details_renders_friendly_404(
     app_runner: None, async_page: Page, server_host_port: str, node_id: NodeID
 ):
@@ -77,7 +75,6 @@ async def test_service_details_renders_friendly_404(
     await assert_contains_text(async_page, "Sorry could not find any details for")
 
 
-@pytest.mark.parametrize("use_internal_scheduler", [False])
 @pytest.mark.parametrize(
     "service_status",
     [