Skip to content

Commit 79d3d8a

Browse files
committed
doc
1 parent 8dd4af9 commit 79d3d8a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

services/web/server/tests/unit/isolated/test_application_settings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@ def mock_service_environment(
239239
service_name: str,
240240
monkeypatch: pytest.MonkeyPatch,
241241
) -> EnvVarsDict:
242+
# NOTE: the name of the service in real deploys are not necessarily the ones we have here in the docker-compose
243+
# Typically they include prefixes with the deployment name e.g. master-webserver or staging-webserver instead of just webserver
242244
print("Mocking envs for service", service_name)
243245

244246
assert docker_compose_service_environment_dict
@@ -249,6 +251,7 @@ def mock_service_environment(
249251
"service_name", ["webserver", "wb-db-event-listener", "wb-garbage-collector"]
250252
)
251253
def test_webserver_rpc_namespace_must_be_default(mock_service_environment: EnvVarsDict):
254+
# NOTE: This requirement will change when https://github.com/ITISFoundation/osparc-simcore/issues/8448 is implemented
252255
settings = ApplicationSettings.create_from_envs() # type: ignore
253256
assert settings
254257

0 commit comments

Comments
 (0)