Skip to content

Commit 7e100e4

Browse files
committed
ensure prometheus metrics are exposed in correct format
1 parent de87f25 commit 7e100e4

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

packages/service-library/src/servicelib/fastapi/monitoring.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@
88
from fastapi import FastAPI, Request, Response, status
99
from fastapi_lifespan_manager import State
1010
from prometheus_client import CollectorRegistry
11-
from prometheus_client.exposition import CONTENT_TYPE_LATEST, generate_latest
11+
from prometheus_client.openmetrics.exposition import (
12+
CONTENT_TYPE_LATEST,
13+
generate_latest,
14+
)
1215
from servicelib.prometheus_metrics import (
1316
PrometheusMetrics,
1417
get_prometheus_metrics,

services/api-server/src/simcore_service_api_server/core/application.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ def init_app(settings: ApplicationSettings | None = None) -> FastAPI:
8787

8888
setup_rabbitmq(app)
8989

90+
if app.state.settings.API_SERVER_PROMETHEUS_INSTRUMENTATION_ENABLED:
91+
setup_prometheus_instrumentation(app)
92+
9093
if settings.API_SERVER_TRACING:
9194
initialize_tracing(app, settings.API_SERVER_TRACING, APP_NAME)
9295

@@ -118,9 +121,6 @@ def init_app(settings: ApplicationSettings | None = None) -> FastAPI:
118121
if settings.API_SERVER_PROFILING:
119122
initialize_profiler(app)
120123

121-
if app.state.settings.API_SERVER_PROMETHEUS_INSTRUMENTATION_ENABLED:
122-
setup_prometheus_instrumentation(app)
123-
124124
exceptions.setup_exception_handlers(
125125
app, is_debug=settings.SC_BOOT_MODE == BootModeEnum.DEBUG
126126
)

0 commit comments

Comments
 (0)