fixed issue

Author: Andrei Neagu

services/agent/src/simcore_service_agent/services/backup.py

@@ -1,18 +1,23 @@
 import asyncio
 import logging
+import os
 import tempfile
 from asyncio.streams import StreamReader
+from datetime import timedelta
 from pathlib import Path
 from textwrap import dedent
 from typing import Final
 from uuid import uuid4
 
 from fastapi import FastAPI
+from servicelib.container_utils import run_command_in_container
 from settings_library.utils_r_clone import resolve_provider
 
 from ..core.settings import ApplicationSettings
 from ..models.volumes import DynamicServiceVolumeLabels, VolumeDetails
 
+_TIMEOUT_PERMISSION_CHANGES: Final[timedelta] = timedelta(minutes=5)
+
 _logger = logging.getLogger(__name__)
 
 
@@ -107,6 +112,15 @@ def _log_expected_operation(
     _logger.log(log_level, formatted_message)
 
 
+async def _ensure_permissions_on_source_dir(source_dir: Path) -> None:
+    self_container = os.environ["HOSTNAME"]
+    await run_command_in_container(
+        self_container,
+        command=f"chmod -R o+rX '{source_dir}'",
+        timeout=_TIMEOUT_PERMISSION_CHANGES.total_seconds(),
+    )
+
+
 async def _store_in_s3(
     settings: ApplicationSettings, volume_name: str, volume_details: VolumeDetails
 ) -> None:
@@ -148,6 +162,8 @@ async def _store_in_s3(
         volume_details.labels, s3_path, r_clone_ls_output, volume_name
     )
 
+    await _ensure_permissions_on_source_dir(source_dir)
+
     # sync files via rclone
     r_clone_sync = [
         "rclone",

services/agent/tests/unit/test_services_backup.py

@@ -1,12 +1,15 @@
 # pylint: disable=redefined-outer-name
+# pylint: disable=unused-argument
 
 import asyncio
-from collections.abc import Awaitable, Callable
+import contextlib
+from collections.abc import AsyncIterable, Awaitable, Callable
 from pathlib import Path
 from typing import Final
 from uuid import uuid4
 
 import aioboto3
+import aiodocker
 import pytest
 from fastapi import FastAPI
 from models_library.projects import ProjectID
@@ -37,6 +40,30 @@ def volume_content(tmpdir: Path) -> Path:
     return path
 
 
+@pytest.fixture
+async def mock_container_with_data(
+    volume_content: Path, monkeypatch: pytest.MonkeyPatch
+) -> AsyncIterable[None]:
+    async with aiodocker.Docker() as client:
+        container = await client.containers.run(
+            config={
+                "Image": "alpine:latest",
+                "Cmd": ["/bin/ash", "-c", "sleep 10000"],
+                "HostConfig": {"Binds": [f"{volume_content}:{volume_content}:rw"]},
+            }
+        )
+        container_inspect = await container.show()
+
+        container_name = container_inspect["Name"][1:]
+        monkeypatch.setenv("HOSTNAME", container_name)
+
+        yield None
+
+        with contextlib.suppress(aiodocker.DockerError):
+            await container.kill()
+        await container.delete()
+
+
 @pytest.fixture
 def downlaoded_from_s3(tmpdir: Path) -> Path:
     path = Path(tmpdir) / "downloaded_from_s3"
@@ -45,6 +72,7 @@ def downlaoded_from_s3(tmpdir: Path) -> Path:
 
 
 async def test_backup_volume(
+    mock_container_with_data: None,
     volume_content: Path,
     project_id: ProjectID,
     swarm_stack_name: str,