Skip to content

Commit 7ec0b78

Browse files
author
Andrei Neagu
committed
properly exposed dynamic-sidecar
1 parent 735526f commit 7ec0b78

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import json
21
import logging
32
from copy import deepcopy
43
from typing import Any, NamedTuple
@@ -176,7 +175,11 @@ def _get_environment_variables(
176175
"S3_SECRET_KEY": r_clone_settings.R_CLONE_S3.S3_SECRET_KEY,
177176
"SC_BOOT_MODE": f"{app_settings.DYNAMIC_SERVICES.DYNAMIC_SIDECAR.DYNAMIC_SIDECAR_SC_BOOT_MODE}",
178177
"SSL_CERT_FILE": app_settings.DIRECTOR_V2_SELF_SIGNED_SSL_FILENAME,
179-
"DYNAMIC_SIDECAR_TRACING": json.dumps(app_settings.DIRECTOR_V2_TRACING),
178+
"DYNAMIC_SIDECAR_TRACING": (
179+
app_settings.DIRECTOR_V2_TRACING.json()
180+
if app_settings.DIRECTOR_V2_TRACING
181+
else "null"
182+
),
180183
# For background info on this special env-var above, see
181184
# - https://stackoverflow.com/questions/31448854/how-to-force-requests-use-the-certificates-on-my-ubuntu-system#comment78596389_37447847
182185
"SIMCORE_HOST_NAME": scheduler_data.service_name,

services/docker-compose-ops.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ services:
111111
- "4318:4318" # OTLP HTTP receiver
112112
networks:
113113
- simcore_default
114+
- interactive_services_subnet
114115
environment:
115116
TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE: ${TRACING_OPENTELEMETRY_COLLECTOR_BATCH_SIZE}
116117
TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE: ${TRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGE}

0 commit comments

Comments
 (0)