Skip to content

Commit 7f3c145

Browse files
authored
πŸ”¨πŸ“ Misc improvements in tooling and doc (#6478)
1 parent 7a2dbda commit 7f3c145

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

β€Žpackages/models-library/Makefileβ€Ž

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,15 @@ erd-ServiceInput.svg: _erdantic
110110
DOWNLOADED_TEST_DATA_DIR = "$(CURDIR)/tests/data/.downloaded-ignore"
111111

112112
.PHONY: _httpx
113-
_httpx: _check_venv_active
113+
_ensure_httpx: _check_venv_active
114114
# ensures requirements installed
115115
@python3 -c "import httpx" 2>/dev/null || uv pip install httpx
116116

117-
PHONY: pull_test_data
118-
pull_test_data: $(DOT_ENV_FILE) _httpx ## downloads tests data from registry (this can take some time!)
119-
# downloading all metadata files
117+
PHONY: tests-data
118+
tests-data: $(DOT_ENV_FILE) _ensure_httpx ## downloads tests data from registry defined in .env (time-intensive!)
119+
# Downloading all metadata files ...
120120
@set -o allexport; \
121121
source $<; \
122122
set +o allexport; \
123123
python3 "$(PACKAGES_DIR)/pytest-simcore/src/pytest_simcore/helpers/docker_registry.py" $(DOWNLOADED_TEST_DATA_DIR)
124+
@echo "Run now 'pytest -vv -m diagnostics tests'"

β€Žpackages/notifications-library/src/notifications_library/templates/on_account_form.email.content.htmlβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<p>Dear Support team
55

66
<p>
7-
We have received the following request form for an account in {{ product.display_name }} from {{ host }}
7+
We have received the following request form for an account in {{ product.display_name }} from <b>{{ host }}</b>
88
</p>
99

1010
<pre>

β€Žpackages/notifications-library/src/notifications_library/templates/on_account_form.email.content.txtβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Dear Support team,
22

3-
We have received the following request form for an account in {{ product.display_name }} from {{ host }}:
3+
We have received the following request form for an account in {{ product.display_name }} from **{{ host }}**:
44

55
{{ dumps(request_form) }}
66

β€Žscripts/maintenance/computational-clusters/autoscaled_monitor/dask.pyβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,13 @@ def _list_tasks(
112112

113113
return dict(task_state_to_tasks)
114114

115+
list_of_tasks: dict[TaskState, list[TaskId]] = []
115116
try:
116-
list_of_tasks: dict[TaskState, list[TaskId]] = await client.run_on_scheduler(
117+
list_of_tasks = await client.run_on_scheduler(
117118
_list_tasks
118119
) # type: ignore
119120
except TypeError:
120-
rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}")
121+
rich.print(f"ERROR while recoverring unrunnable tasks using {dask_client=}. Defaulting to empty list of tasks!!")
121122
return list_of_tasks
122123

123124

0 commit comments

Comments
Β (0)