refactor setup and optional values

Author: Andrei Neagu

packages/service-library/src/servicelib/fastapi/http_client_thin.py

@@ -200,10 +200,10 @@ def __init__(
         self,
         *,
         total_retry_interval: float,
+        tracing_settings: TracingSettings | None,
         base_url: URLTypes | None = None,
         default_http_client_timeout: TimeoutTypes | None = None,
         extra_allowed_method_names: set[str] | None = None,
-        tracing_settings: TracingSettings | None = None,
     ) -> None:
         _assert_public_interface(self, extra_allowed_method_names)
 

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v0/_setup.py

@@ -1,28 +1,12 @@
 from fastapi import FastAPI
 
-from ...core.settings import ApplicationSettings
 from ._public_client import DirectorV0PublicClient
 from ._thin_client import DirectorV0ThinClient
 
 
 def setup_director_v0(app: FastAPI) -> None:
-    settings: ApplicationSettings = app.state.settings
-
     async def _on_startup() -> None:
-        assert settings.CLIENT_REQUEST.HTTP_CLIENT_REQUEST_TOTAL_TIMEOUT  # nosec
-        thin_client = DirectorV0ThinClient(
-            total_retry_interval=int(
-                settings.CLIENT_REQUEST.HTTP_CLIENT_REQUEST_TOTAL_TIMEOUT
-            ),
-            extra_allowed_method_names={
-                "attach_lifespan_to",
-                "get_from_app_state",
-                "pop_from_app_state",
-                "set_to_app_state",
-            },
-            base_url=settings.DYNAMIC_SCHEDULER_DIRECTOR_V0_SETTINGS.endpoint,
-            tracing_settings=settings.DYNAMIC_SCHEDULER_TRACING,
-        )
+        thin_client = DirectorV0ThinClient(app)
         thin_client.set_to_app_state(app)
         thin_client.attach_lifespan_to(app)
 

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v0/_thin_client.py

@@ -1,7 +1,7 @@
 import urllib.parse
 
 from common_library.unset import as_dict_exclude_none
-from fastapi import status
+from fastapi import FastAPI, status
 from httpx import Response
 from models_library.projects import ProjectID
 from models_library.projects_nodes_io import NodeID
@@ -16,12 +16,32 @@
 )
 from yarl import URL
 
+from ...core.settings import ApplicationSettings
+
 
 class DirectorV0ThinClient(
     SingletonInAppStateMixin, BaseThinClient, AttachLifespanMixin
 ):
     app_state_name: str = "director_v0_thin_client"
 
+    def __init__(self, app: FastAPI) -> None:
+        settings: ApplicationSettings = app.state.settings
+        assert settings.CLIENT_REQUEST.HTTP_CLIENT_REQUEST_TOTAL_TIMEOUT  # nosec
+
+        super().__init__(
+            total_retry_interval=int(
+                settings.CLIENT_REQUEST.HTTP_CLIENT_REQUEST_TOTAL_TIMEOUT
+            ),
+            extra_allowed_method_names={
+                "attach_lifespan_to",
+                "get_from_app_state",
+                "pop_from_app_state",
+                "set_to_app_state",
+            },
+            base_url=settings.DYNAMIC_SCHEDULER_DIRECTOR_V0_SETTINGS.endpoint,
+            tracing_settings=settings.DYNAMIC_SCHEDULER_TRACING,
+        )
+
     @retry_on_errors()
     @expect_status(status.HTTP_200_OK)
     async def get_running_interactive_service_details(