Skip to content

Commit 7feeff6

Browse files
author
Andrei Neagu
committed
fixed test
1 parent 89201e6 commit 7feeff6

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

packages/service-library/tests/deferred_tasks/test__base_deferred_handler.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ class MockKeys(StrAutoEnum):
4343
GET_TIMEOUT = auto()
4444
START_DEFERRED = auto()
4545
ON_DEFERRED_CREATED = auto()
46-
RUN_DEFERRED = auto()
46+
RUN_DEFERRED_BEFORE_HADNLER = auto()
47+
RUN_DEFERRED_AFTER_HANDLER = auto()
4748
ON_DEFERRED_RESULT = auto()
4849
ON_FINISHED_WITH_ERROR = auto()
4950

@@ -123,8 +124,9 @@ async def on_created(
123124

124125
@classmethod
125126
async def run(cls, context: DeferredContext) -> Any:
127+
mocks[MockKeys.RUN_DEFERRED_BEFORE_HADNLER](context)
126128
result = await run(context)
127-
mocks[MockKeys.RUN_DEFERRED](context)
129+
mocks[MockKeys.RUN_DEFERRED_AFTER_HANDLER](context)
128130
return result
129131

130132
@classmethod
@@ -230,8 +232,8 @@ async def _run_ok(_: DeferredContext) -> Any:
230232
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_CREATED, count=1)
231233
assert TaskUID(mocks[MockKeys.ON_DEFERRED_CREATED].call_args_list[0].args[0])
232234

233-
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED, count=1)
234-
mocks[MockKeys.RUN_DEFERRED].assert_called_once_with(context)
235+
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_AFTER_HANDLER, count=1)
236+
mocks[MockKeys.RUN_DEFERRED_AFTER_HANDLER].assert_called_once_with(context)
235237

236238
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_RESULT, count=1)
237239
mocks[MockKeys.ON_DEFERRED_RESULT].assert_called_once_with(run_return, context)
@@ -283,7 +285,7 @@ async def _run_raises(_: DeferredContext) -> None:
283285
count=retry_count,
284286
)
285287

286-
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED, count=0)
288+
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_AFTER_HANDLER, count=0)
287289
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_RESULT, count=0)
288290

289291
await _assert_log_message(
@@ -320,6 +322,7 @@ async def _run_to_cancel(_: DeferredContext) -> None:
320322
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_CREATED, count=1)
321323
task_uid = TaskUID(mocks[MockKeys.ON_DEFERRED_CREATED].call_args_list[0].args[0])
322324

325+
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_BEFORE_HADNLER, count=1)
323326
await mocked_deferred_handler.cancel(task_uid)
324327

325328
await _assert_mock_call(mocks, key=MockKeys.ON_FINISHED_WITH_ERROR, count=0)
@@ -331,7 +334,7 @@ async def _run_to_cancel(_: DeferredContext) -> None:
331334
== 0
332335
)
333336

334-
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED, count=0)
337+
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_AFTER_HANDLER, count=0)
335338
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_RESULT, count=0)
336339

337340
await _assert_log_message(
@@ -451,7 +454,7 @@ async def _run_that_times_out(_: DeferredContext) -> None:
451454
for entry in mocks[MockKeys.ON_FINISHED_WITH_ERROR].call_args_list:
452455
assert "builtins.TimeoutError" in entry.args[0].error
453456

454-
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED, count=0)
457+
await _assert_mock_call(mocks, key=MockKeys.RUN_DEFERRED_AFTER_HANDLER, count=0)
455458
await _assert_mock_call(mocks, key=MockKeys.ON_DEFERRED_RESULT, count=0)
456459

457460

0 commit comments

Comments
 (0)