refactor and checkFunctionPermissions

Author: odeimaiz

services/static-webserver/client/source/class/osparc/data/Permissions.js

@@ -192,6 +192,9 @@ qx.Class.define("osparc.data.Permissions", {
   },
 
   members: {
+    __permissions: null,
+    __functionPermissions: null,
+
     arePermissionsReady() {
       return this.getRole() !== null;
     },
@@ -276,37 +279,44 @@ qx.Class.define("osparc.data.Permissions", {
       return canDo;
     },
 
+    fetchPermissions: function() {
+      osparc.data.Resources.get("permissions")
+        .then(permissions => {
+          this.__permissions = permissions;
+        })
+        .catch(err => console.error(err));
+    },
+
     checkMyGroupCanDo: function(action) {
-      return new Promise((resolve, reject) => {
-        osparc.data.Resources.get("permissions")
-          .then(permissions => {
-            const found = permissions.find(permission => permission["name"] === action);
-            if (found) {
-              resolve(found["allowed"]);
-            } else {
-              resolve(false);
-            }
-          })
-          .catch(err => reject(err));
-      });
+      if (this.__permissions) {
+        const found = this.__permissions.find(permission => permission["name"] === action);
+        if (found) {
+          return found["allowed"];
+        }
+      }
+      return false;
+    },
+
+    fetchFunctionPermissions: function() {
+      osparc.data.Resources.get("functionPermissions")
+        .then(functionPermissions => {
+          this.__functionPermissions = functionPermissions;
+        })
+        .catch(err => console.error(err));
     },
 
     checkFunctionPermissions: function(action) {
       if (osparc.utils.DisabledPlugins.isFunctionsDisabled()) {
-        return Promise.resolve(false);
+        return false;
       }
 
-      return new Promise((resolve, reject) => {
-        osparc.data.Resources.get("functionPermissions")
-          .then(functionPermissions => {
-            if (action in functionPermissions) {
-              resolve(functionPermissions[action]);
-            } else {
-              resolve(false);
-            }
-          })
-          .catch(err => reject(err));
-      });
+      if (
+        this.__functionPermissions &&
+        action in this.__functionPermissions
+      ) {
+        return functionPermissions[action];
+      }
+      return false;
     },
 
     isTester: function() {

services/static-webserver/client/source/class/osparc/desktop/MainPage.js

@@ -70,7 +70,8 @@ qx.Class.define("osparc.desktop.MainPage", {
     preloadPromises.push(osparc.store.Products.getInstance().fetchUiConfig());
     preloadPromises.push(osparc.store.PollTasks.getInstance().fetchTasks());
     preloadPromises.push(osparc.store.Jobs.getInstance().fetchJobsLatest());
-    preloadPromises.push(osparc.data.Resources.get("permissions"));
+    preloadPromises.push(osparc.data.Permissions.getInstance().fetchPermissions());
+    preloadPromises.push(osparc.data.Permissions.getInstance().fetchFunctionPermissions());
     Promise.all(preloadPromises)
       .then(() => {
         const mainStack = this.__createMainStack();

services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js

@@ -1090,8 +1090,6 @@ qx.Class.define("osparc.desktop.WorkbenchView", {
       }
 
       const nodeOptions = new osparc.widget.NodeOptions(node);
-      nodeOptions.buildLayout();
-
       return nodeOptions;
     },
 

services/static-webserver/client/source/class/osparc/widget/NodeOptions.js

@@ -36,7 +36,8 @@ qx.Class.define("osparc.widget.NodeOptions", {
   properties: {
     node: {
       check: "osparc.data.model.Node",
-      nullable: false
+      nullable: false,
+      apply: "__buildLayout",
     }
   },
 
@@ -46,7 +47,7 @@ qx.Class.define("osparc.widget.NodeOptions", {
       this.show();
     },
 
-    buildLayout: async function() {
+    __buildLayout: function() {
       const node = this.getNode();
 
       const sections = [];
@@ -83,7 +84,7 @@ qx.Class.define("osparc.widget.NodeOptions", {
 
       // Update Resource Limits
       if (
-        await osparc.data.Permissions.getInstance().checkMyGroupCanDo("override_services_specifications") &&
+        osparc.data.Permissions.getInstance().checkMyGroupCanDo("override_services_specifications") &&
         (node.isComputational() || node.isDynamic())
       ) {
         const updateResourceLimitsView = new osparc.node.UpdateResourceLimitsView(node);