Updates Node model and cleanup

Author: pcrespov

packages/models-library/src/models_library/projects_nodes.py

@@ -383,7 +383,8 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
 
     model_config = ConfigDict(
         extra="forbid",
-        populate_by_name=True,
+        validate_by_name=True,
+        validate_by_alias=True,
         json_schema_extra=_update_json_schema_extra,
     )
 

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_utils.py

@@ -400,6 +400,9 @@ async def generate_tasks_list_from_project(
             raise WalletNotEnoughCreditsError(
                 wallet_name=wallet_info.wallet_name,
                 wallet_credit_amount=wallet_info.wallet_credit_amount,
+                user_id=user_id,
+                product_name=product_name,
+                project_id=project.uuid,
             )
 
         assert rabbitmq_rpc_client  # nosec

services/director-v2/src/simcore_service_director_v2/utils/dags.py

@@ -29,6 +29,7 @@ def create_complete_dag(workbench: NodesDict) -> nx.DiGraph:
     dag_graph: nx.DiGraph = nx.DiGraph()
     for node_id, node in workbench.items():
         assert node.state  # nosec
+
         dag_graph.add_node(
             node_id,
             name=node.label,
@@ -43,6 +44,9 @@ def create_complete_dag(workbench: NodesDict) -> nx.DiGraph:
         if node.input_nodes:
             for input_node_id in node.input_nodes:
                 predecessor_node = workbench.get(NodeIDStr(input_node_id))
+                assert (
+                    predecessor_node
+                ), f"Node {input_node_id} not found in workbench"  # nosec
                 if predecessor_node:
                     dag_graph.add_edge(str(input_node_id), node_id)