acceptance tests

Author: pcrespov

services/web/server/src/simcore_service_webserver/users/_users_rest.py

@@ -153,14 +153,15 @@ async def get_user(request: web.Request) -> web.Response:
     return envelope_json_response(UserGet.from_model(user))
 
 
-@routes.get(f"/{API_VTAG}/users:search", name="search_users")
+@routes.post(f"/{API_VTAG}/users:search", name="search_users")
 @login_required
 @permission_required("user.read")
 @_handle_users_exceptions
 async def search_users(request: web.Request) -> web.Response:
     req_ctx = UsersRequestContext.model_validate(request)
     assert req_ctx.product_name  # nosec
 
+    # NOTE: Decided for body instead of query parameters because it is easier for the front-end
     search_params = await parse_request_body_as(UsersSearch, request)
 
     found = await _users_service.search_public_users(

services/web/server/tests/unit/with_dbs/03/test_users.py

@@ -18,9 +18,14 @@
 from aiopg.sa.connection import SAConnection
 from faker import Faker
 from models_library.api_schemas_webserver.auth import AccountRequestInfo
-from models_library.api_schemas_webserver.users import MyProfileGet, UserForAdminGet
+from models_library.api_schemas_webserver.users import (
+    MyProfileGet,
+    UserForAdminGet,
+    UserGet,
+)
 from models_library.generics import Envelope
 from psycopg2 import OperationalError
+from pydantic import TypeAdapter
 from pytest_simcore.helpers.assert_checks import assert_status
 from pytest_simcore.helpers.faker_factories import (
     DEFAULT_TEST_PASSWORD,
@@ -54,6 +59,40 @@ def app_environment(
     )
 
 
+@pytest.mark.parametrize("user_role", [UserRole.USER])
+async def test_get_and_search_public_users(
+    user: UserInfoDict,
+    logged_user: UserInfoDict,
+    client: TestClient,
+    user_role: UserRole,
+):
+    assert client.app
+    assert user_role == logged_user["role"]
+    other_user = user
+
+    assert other_user["id"] != logged_user["id"]
+
+    # GET user
+    url = client.app.router["get_user"].url_for(user_id=f'{other_user["id"]}')
+    resp = await client.get(f"{url}")
+    data, _ = await assert_status(resp, status.HTTP_200_OK)
+
+    got = UserGet.model_validate(data)
+    assert got.user_id == other_user["id"]
+    assert got.user_name == other_user["name"]
+
+    # SEARCH user
+    partial_email = other_user["email"][:-5]
+    url = client.app.router["search_users"].url_for().with_query(match=partial_email)
+    resp = await client.post(f"{url}")
+    data, _ = await assert_status(resp, status.HTTP_200_OK)
+
+    found = TypeAdapter(list[UserGet]).validate_python(data)
+    assert found
+    assert len(found) == 1
+    assert found[0] == got
+
+
 @pytest.mark.parametrize(
     "user_role,expected",
     [