remove unnecessary events

Author: odeimaiz

services/static-webserver/client/source/class/osparc/data/model/Node.js

@@ -196,7 +196,6 @@ qx.Class.define("osparc.data.model.Node", {
   },
 
   events: {
-    "updateStudyDocument": "qx.event.type.Event",
     "projectDocumentChanged": "qx.event.type.Data",
     "reloadModel": "qx.event.type.Event",
     "retrieveInputs": "qx.event.type.Data",

services/static-webserver/client/source/class/osparc/data/model/Workbench.js

@@ -50,9 +50,7 @@ qx.Class.define("osparc.data.model.Workbench", {
   },
 
   events: {
-    "updateStudyDocument": "qx.event.type.Event",
     "projectDocumentChanged": "qx.event.type.Data",
-    "restartAutoSaveTimer": "qx.event.type.Event",
     "pipelineChanged": "qx.event.type.Event",
     "nodeAdded": "qx.event.type.Data",
     "nodeRemoved": "qx.event.type.Data",
@@ -352,7 +350,6 @@ qx.Class.define("osparc.data.model.Workbench", {
         return null;
       }
 
-      this.fireEvent("restartAutoSaveTimer");
       // create the node in the backend first
       const params = {
         url: {
@@ -368,7 +365,6 @@ qx.Class.define("osparc.data.model.Workbench", {
         const resp = await osparc.data.Resources.fetch("studies", "addNode", params);
         const nodeId = resp["node_id"];
 
-        this.fireEvent("restartAutoSaveTimer");
         const node = this.__createNode(key, version, nodeId);
         node.fetchMetadataAndPopulate()
           .then(() => {
@@ -394,15 +390,11 @@ qx.Class.define("osparc.data.model.Workbench", {
     },
 
     __initNodeSignals: function(node) {
-      if (osparc.utils.Utils.eventDrivenPatch()) {
-        node.listenToChanges();
-        node.addListener("projectDocumentChanged", e => this.fireDataEvent("projectDocumentChanged", e.getData()), this);
-      }
+      node.listenToChanges();
+      node.addListener("projectDocumentChanged", e => this.fireDataEvent("projectDocumentChanged", e.getData()), this);
       node.addListener("keyChanged", () => this.fireEvent("reloadModel"), this);
       node.addListener("changeInputNodes", () => this.fireDataEvent("pipelineChanged"), this);
       node.addListener("reloadModel", () => this.fireEvent("reloadModel"), this);
-      node.addListener("updateStudyDocument", () => this.fireEvent("updateStudyDocument"), this);
-
       node.addListener("showInLogger", e => this.fireDataEvent("showInLogger", e.getData()), this);
       node.addListener("retrieveInputs", e => this.fireDataEvent("retrieveInputs", e.getData()), this);
       node.addListener("fileRequested", e => this.fireDataEvent("fileRequested", e.getData()), this);
@@ -633,7 +625,6 @@ qx.Class.define("osparc.data.model.Workbench", {
         return;
       }
 
-      this.fireEvent("restartAutoSaveTimer");
       let node = this.getNode(nodeId);
       if (node) {
         // remove the node in the backend first
@@ -645,8 +636,6 @@ qx.Class.define("osparc.data.model.Workbench", {
     },
 
     __nodeRemoved: function(nodeId) {
-      this.fireEvent("restartAutoSaveTimer");
-
       delete this.__nodes[nodeId];
 
       // remove first the connected edges
@@ -1002,14 +991,11 @@ qx.Class.define("osparc.data.model.Workbench", {
     __createNodeOld: function(metadata, nodeId) {
       const node = new osparc.data.model.Node(this.getStudy(), metadata["key"], metadata["version"], nodeId);
       node.setMetadata(metadata);
-      if (osparc.utils.Utils.eventDrivenPatch()) {
-        node.listenToChanges();
-        node.addListener("projectDocumentChanged", e => this.fireDataEvent("projectDocumentChanged", e.getData()), this);
-      }
+      node.listenToChanges();
+      node.addListener("projectDocumentChanged", e => this.fireDataEvent("projectDocumentChanged", e.getData()), this);
       node.addListener("keyChanged", () => this.fireEvent("reloadModel"), this);
       node.addListener("changeInputNodes", () => this.fireDataEvent("pipelineChanged"), this);
       node.addListener("reloadModel", () => this.fireEvent("reloadModel"), this);
-      node.addListener("updateStudyDocument", () => this.fireEvent("updateStudyDocument"), this);
       osparc.utils.Utils.localCache.serviceToFavs(metadata["key"]);
 
       this.__initNodeSignals(node);

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js

@@ -287,13 +287,8 @@ qx.Class.define("osparc.desktop.StudyEditor", {
         this.nodeSelected(nodeId);
       }, this);
 
-      if (osparc.utils.Utils.eventDrivenPatch()) {
-        study.listenToChanges(); // this includes the listener on the workbench and ui
-        study.addListener("projectDocumentChanged", e => this.projectDocumentChanged(e.getData()), this);
-      } else {
-        workbench.addListener("updateStudyDocument", () => this.updateStudyDocument());
-        workbench.addListener("restartAutoSaveTimer", () => this.__restartAutoSaveTimer());
-      }
+      study.listenToChanges(); // this includes the listener on the workbench and ui
+      study.addListener("projectDocumentChanged", e => this.projectDocumentChanged(e.getData()), this);
 
       if (osparc.utils.DisabledPlugins.isRTCEnabled()) {
         this.__listenToProjectDocument();

services/static-webserver/client/source/class/osparc/node/BootOptionsView.js

@@ -54,7 +54,6 @@ qx.Class.define("osparc.node.BootOptionsView", {
             "boot_mode": newBootModeId
           };
           node.setBootOptions(data);
-          node.fireEvent("updateStudyDocument");
           node.fireDataEvent("projectDocumentChanged", {
             "op": "replace",
             "path": `/workbench/${nodeId}/bootOptions`,

services/static-webserver/client/source/class/osparc/node/LifeCycleView.js

@@ -119,7 +119,6 @@ qx.Class.define("osparc.node.LifeCycleView", {
           newData["version"] = latestCompatible["version"];
         }
         node.set(newData);
-        node.fireEvent("updateStudyDocument");
         node.fireDataEvent("projectDocumentChanged", [{
           "op": "replace",
           "path": `/workbench/${nodeId}/key`,

services/static-webserver/client/source/class/osparc/utils/Utils.js

@@ -542,10 +542,6 @@ qx.Class.define("osparc.utils.Utils", {
       return (["dev", "master"].includes(platformName));
     },
 
-    eventDrivenPatch: function() {
-      return osparc.utils.DisabledPlugins.isRTCEnabled();
-    },
-
     getEditButton: function(isVisible = true) {
       return new qx.ui.form.Button(null, "@FontAwesome5Solid/pencil-alt/12").set({
         appearance: "form-button-outlined",