🎨E2E: fixing fail fast when websocket messages missing, fixing missing yield (#7602)

Author: sanderegg

packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py

@@ -401,6 +401,7 @@ class SocketIONodeProgressCompleteWaiter:
     )
     _last_progress_time: datetime = field(default_factory=lambda: datetime.now(tz=UTC))
     _received_messages: list[SocketIOEvent] = field(default_factory=list)
+    _result: bool = False
 
     def __call__(self, message: str) -> bool:
         # socket.io encodes messages like so
@@ -422,6 +423,7 @@ def __call__(self, message: str) -> bool:
                     self.node_id,
                     decoded_message.obj["service_state"],
                 )
+                self._result = False
                 return True
             if decoded_message.name == _OSparcMessages.NODE_PROGRESS.value:
                 node_progress_event = retrieve_node_progress_from_decoded_message(
@@ -449,13 +451,11 @@ def __call__(self, message: str) -> bool:
                             f"{json.dumps({k: round(v, 2) for k, v in self._current_progress.items()})}",
                         )
 
-                progress_completed = self.got_expected_node_progress_types() and all(
-                    round(progress, 1) == 1.0
-                    for progress in self._current_progress.values()
-                )
-                if progress_completed:
+                done = self._completed_successfully()
+                if done:
+                    self._result = True
                     self.logger.info("✅ Service start completed successfully!! ✅")
-                return progress_completed
+                return done
 
         time_since_last_progress = datetime.now(UTC) - self._last_progress_time
         if time_since_last_progress > self.max_idle_timeout:
@@ -469,15 +469,17 @@ def __call__(self, message: str) -> bool:
 
         return False
 
-    def got_expected_node_progress_types(self) -> bool:
+    def _completed_successfully(self) -> bool:
         return all(
             progress_type in self._current_progress
             for progress_type in NodeProgressType.required_types_for_started_service()
+        ) and all(
+            round(progress, 1) == 1.0 for progress in self._current_progress.values()
         )
 
     @property
-    def number_received_messages(self) -> int:
-        return len(self._received_messages)
+    def success(self) -> bool:
+        return self._result
 
 
 def wait_for_service_endpoint_responding(
@@ -597,7 +599,9 @@ def expected_service_running(
                 msg=f"Waiting for node to run. Timeout: {timeout}",
             )
         )
+
         if is_service_legacy:
+            waiter = None
             ctx.logger.info(
                 "⚠️ Legacy service detected. We are skipping websocket messages in this case! ⚠️"
             )
@@ -612,7 +616,11 @@ def expected_service_running(
         service_running = ServiceRunning(iframe_locator=None)
         if press_start_button:
             _trigger_service_start(page, node_id)
+        yield service_running
+
     elapsed_time = arrow.utcnow() - started
+    if waiter and not waiter.success:
+        pytest.fail("❌ Service failed starting!  ❌")
 
     wait_for_service_endpoint_responding(
         node_id,
@@ -652,6 +660,7 @@ def wait_for_service_running(
             )
         )
         if is_service_legacy:
+            waiter = None
             ctx.logger.info(
                 "⚠️ Legacy service detected. We are skipping websocket messages in this case! ⚠️"
             )
@@ -666,6 +675,9 @@ def wait_for_service_running(
         if press_start_button:
             _trigger_service_start(page, node_id)
     elapsed_time = arrow.utcnow() - started
+
+    if waiter and not waiter.success:
+        pytest.fail("❌ Service failed starting!  ❌")
     wait_for_service_endpoint_responding(
         node_id,
         api_request_context=page.request,