review @pcrespov

Author: matusdrobuliak66

packages/models-library/src/models_library/licenses.py

@@ -107,7 +107,7 @@ class LicensedResourceDB(BaseModel):
     model_config = ConfigDict(from_attributes=True)
 
 
-class LicensedResourceUpdateDB(BaseModel):
+class LicensedResourcePatchDB(BaseModel):
     display_name: str | None = None
     licensed_resource_name: str | None = None
     trash: bool | None = None

services/web/server/src/simcore_service_webserver/licenses/_itis_vip_syncer_service.py

@@ -46,7 +46,7 @@ async def sync_resources_with_licensed_items(
                 with log_context(
                     _logger, logging.INFO, "Registering %s", licensed_resource_name
                 ), log_catch(_logger, reraise=False):
-                    result = await _licensed_items_service.register_resource_as_licensed_resource(
+                    result = await _licensed_items_service.register_licensed_resource(
                         app,
                         licensed_item_display_name=f"{vip_data.features.get('name', 'UNNAMED!!')} "
                         f"{vip_data.features.get('version', 'UNVERSIONED!!')}",

services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py

@@ -51,7 +51,7 @@ class RegistrationResult(NamedTuple):
     message: str | None
 
 
-async def register_resource_as_licensed_resource(
+async def register_licensed_resource(
     app: web.Application,
     *,
     licensed_resource_name: str,

services/web/server/tests/unit/with_dbs/04/licenses/test_itis_vip_service.py

@@ -146,7 +146,7 @@ async def test_sync_itis_vip_as_licensed_items(
                     licensed_item1,
                     state1,
                     _,
-                ) = await _licensed_items_service.register_resource_as_licensed_resource(
+                ) = await _licensed_items_service.register_licensed_resource(
                     client.app,
                     licensed_resource_name=f"{category}/{vip.id}",
                     licensed_resource_type=LicensedResourceType.VIP_MODEL,
@@ -160,7 +160,7 @@ async def test_sync_itis_vip_as_licensed_items(
                     licensed_item2,
                     state2,
                     _,
-                ) = await _licensed_items_service.register_resource_as_licensed_resource(
+                ) = await _licensed_items_service.register_licensed_resource(
                     client.app,
                     licensed_resource_name=f"{category}/{vip.id}",
                     licensed_resource_type=LicensedResourceType.VIP_MODEL,
@@ -176,7 +176,7 @@ async def test_sync_itis_vip_as_licensed_items(
                     licensed_item3,
                     state3,
                     msg,
-                ) = await _licensed_items_service.register_resource_as_licensed_resource(
+                ) = await _licensed_items_service.register_licensed_resource(
                     client.app,
                     licensed_resource_name=f"{category}/{vip.id}",
                     licensed_resource_type=LicensedResourceType.VIP_MODEL,