@pcrespov improve sorted function name

Author: bisgaard-itis

packages/pytest-simcore/src/pytest_simcore/helpers/catalog_rpc_server.py

@@ -122,7 +122,7 @@ async def update_service(
         return got.model_copy(update=update.model_dump(exclude_unset=True))
 
     @validate_call(config={"arbitrary_types_allowed": True})
-    async def list_my_service_history_sorted(
+    async def list_my_service_history_latest_first(
         self,
         rpc_client: RabbitMQRPCClient | MockType,
         *,

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py

@@ -194,7 +194,7 @@ async def batch_get_my_services(
 
 
 @validate_call(config={"arbitrary_types_allowed": True})
-async def list_my_service_history_sorted(  # pylint: disable=too-many-arguments
+async def list_my_service_history_latest_first(  # pylint: disable=too-many-arguments
     rpc_client: RabbitMQRPCClient,
     *,
     product_name: ProductName,
@@ -211,7 +211,9 @@ async def list_my_service_history_sorted(  # pylint: disable=too-many-arguments
     """
     result = await rpc_client.request(
         CATALOG_RPC_NAMESPACE,
-        TypeAdapter(RPCMethodName).validate_python("list_my_service_history_sorted"),
+        TypeAdapter(RPCMethodName).validate_python(
+            "list_my_service_history_latest_first"
+        ),
         product_name=product_name,
         user_id=user_id,
         service_key=service_key,

services/api-server/src/simcore_service_api_server/services_rpc/catalog.py

@@ -81,7 +81,7 @@ async def list_release_history_sorted(
         limit: PageLimitInt = DEFAULT_NUMBER_OF_ITEMS_PER_PAGE,
     ) -> tuple[list[ServiceRelease], PageMetaInfoLimitOffset]:
 
-        page = await catalog_rpc.list_my_service_history_sorted(
+        page = await catalog_rpc.list_my_service_history_latest_first(
             self._client,
             product_name=product_name,
             user_id=user_id,

services/api-server/tests/unit/conftest.py

@@ -490,11 +490,11 @@ def get_mock_rabbitmq_rpc_client():
             autospec=True,
             side_effect=side_effects.update_service,
         ),
-        "list_my_service_history_sorted": mocker.patch.object(
+        "list_my_service_history_latest_first": mocker.patch.object(
             catalog_rpc,
-            "list_my_service_history_sorted",
+            "list_my_service_history_latest_first",
             autospec=True,
-            side_effect=side_effects.list_my_service_history_sorted,
+            side_effect=side_effects.list_my_service_history_latest_first,
         ),
         "get_service_ports": mocker.patch.object(
             catalog_rpc,

services/api-server/tests/unit/test_services_catalog.py

@@ -85,6 +85,6 @@ async def test_catalog_service_read_solvers(
 
     # checks calls to rpc
     mocked_catalog_rpc_api["list_services_paginated"].assert_called_once()
-    mocked_catalog_rpc_api["list_my_service_history_sorted"].assert_called_once()
+    mocked_catalog_rpc_api["list_my_service_history_latest_first"].assert_called_once()
     mocked_catalog_rpc_api["get_service"].assert_called_once()
     mocked_catalog_rpc_api["get_service_ports"].assert_called_once()

services/catalog/src/simcore_service_catalog/api/rpc/_services.py

@@ -242,7 +242,7 @@ async def batch_get_my_services(
 @router.expose(reraise_if_error_type=(ValidationError,))
 @log_decorator(_logger, level=logging.DEBUG)
 @validate_call(config={"arbitrary_types_allowed": True})
-async def list_my_service_history_sorted(
+async def list_my_service_history_latest_first(
     app: FastAPI,
     *,
     product_name: ProductName,

services/catalog/tests/unit/with_dbs/test_api_rpc.py

@@ -560,7 +560,7 @@ async def test_rpc_list_my_service_history_paginated(
     await services_db_tables_injector(fake_releases + unrelated_releases)
 
     # Call the RPC function
-    page = await catalog_rpc.list_my_service_history_sorted(
+    page = await catalog_rpc.list_my_service_history_latest_first(
         rpc_client,
         product_name=product_name,
         user_id=user_id,