fixed issue with method registration

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_tasks/_rabbit/lrt_server.py

@@ -1,9 +1,6 @@
 import logging
 from typing import Any
 
-from common_library.error_codes import create_error_code
-
-from ...logging_errors import create_troubleshootting_log_kwargs
 from ...rabbitmq import RPCRouter
 from .._serialization import object_to_string
 from ..base_long_running_manager import BaseLongRunningManager
@@ -74,15 +71,7 @@ async def _get_transferarble_task_result(
         return task_result
     except (TaskNotFoundError, TaskNotCompletedError):
         raise
-    except Exception as exc:
-        _logger.exception(
-            **create_troubleshootting_log_kwargs(
-                user_error_msg=f"{task_id=} raised an exception while getting its result",
-                error=exc,
-                error_code=create_error_code(exc),
-                error_context={"task_context": task_context, "task_id": task_id},
-            ),
-        )
+    except Exception:
         # the task shall be removed in this case
         await long_running_manager.tasks_manager.remove_task(
             task_id, with_task_context=task_context, reraise_errors=False

packages/service-library/src/servicelib/long_running_tasks/task.py

@@ -60,15 +60,10 @@ def __name__(self) -> str: ...
 class TaskRegistry:
     REGISTERED_TASKS: ClassVar[dict[RegisteredTaskName, TaskProtocol]] = {}
 
-    # TODO: maybe only use one method to register
     @classmethod
-    def register(cls, task: TaskProtocol) -> None:
-        cls.REGISTERED_TASKS[task.__name__] = task
-
-    @classmethod
-    def register_partial(cls, task: TaskProtocol, **partial_kwargs) -> None:
+    def register(cls, task: TaskProtocol, **partial_kwargs) -> None:
         partail_task = functools.partial(task, **partial_kwargs)
-        # allows to call via the partial of via the orignal method
+        # allows to call the partial via it's original name
         partail_task.__name__ = task.__name__  # type: ignore[attr-defined]
         cls.REGISTERED_TASKS[task.__name__] = partail_task  # type: ignore[assignment]
 

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.py

@@ -672,6 +672,6 @@ async def on_startup() -> None:
         }
 
         for handler, context in task_context.items():
-            TaskRegistry.register_partial(handler, **context)
+            TaskRegistry.register(handler, **context)
 
     app.add_event_handler("startup", on_startup)

services/web/server/src/simcore_service_webserver/long_running_tasks.py

@@ -10,18 +10,21 @@
 )
 from servicelib.aiohttp.long_running_tasks.server import setup
 from servicelib.aiohttp.typing_extension import Handler
-from servicelib.long_running_tasks.models import RabbitNamespace
-from servicelib.long_running_tasks.task import RedisNamespace
 
 from . import rabbitmq_settings, redis
 from ._meta import API_VTAG
 from .login.decorators import login_required
 from .models import AuthenticatedRequestContext
+from .projects.plugin import register_projects_long_running_tasks
 
 _logger = logging.getLogger(__name__)
 
-_LRT_REDIS_NAMESPACE: Final[RedisNamespace] = "webserver-legacy"
-_LRT_RABBIT_NAMESPACE: Final[RabbitNamespace] = "webserver-legacy"
+
+_LRT_NAMESPACE_PREFIX: Final[str] = "webserver-legacy"
+
+
+def _get_namespace(suffix: str) -> str:
+    return f"{_LRT_NAMESPACE_PREFIX}-{suffix}"
 
 
 def webserver_request_context_decorator(handler: Handler):
@@ -39,13 +42,17 @@ async def _test_task_context_decorator(
 
 @ensure_single_setup(__name__, logger=_logger)
 def setup_long_running_tasks(app: web.Application) -> None:
+    # register all long-running tasks from different modules
+    register_projects_long_running_tasks(app)
+
+    namespace_suffix = "TODO"  # TODO recover from settings
 
     setup(
         app,
         redis_settings=redis.get_plugin_settings(app),
         rabbit_settings=rabbitmq_settings.get_plugin_settings(app),
-        redis_namespace=_LRT_REDIS_NAMESPACE,
-        rabbit_namespace=_LRT_RABBIT_NAMESPACE,
+        redis_namespace=_get_namespace(namespace_suffix),
+        rabbit_namespace=_get_namespace(namespace_suffix),
         router_prefix=f"/{API_VTAG}/tasks-legacy",
         handler_check_decorator=login_required,
         task_request_context_decorator=webserver_request_context_decorator,

services/web/server/src/simcore_service_webserver/projects/_controller/nodes_rest.py

@@ -323,7 +323,7 @@ async def _stop_dynamic_service_task(
 
 
 def register_stop_dynamic_service_task(app: web.Application) -> None:
-    TaskRegistry.register_partial(_stop_dynamic_service_task, app=app)
+    TaskRegistry.register(_stop_dynamic_service_task, app=app)
 
 
 @routes.post(

services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py

@@ -522,8 +522,4 @@ async def create_project(  # pylint: disable=too-many-arguments,too-many-branche
 
 
 def register_create_project_task(app: web.Application) -> None:
-    TaskRegistry.register_partial(create_project, app=app)
-    _logger.debug(
-        "I've manged to register the create_project task %s",
-        TaskRegistry.REGISTERED_TASKS,
-    )
+    TaskRegistry.register(create_project, app=app)

services/web/server/src/simcore_service_webserver/projects/plugin.py

@@ -37,6 +37,11 @@
 logger = logging.getLogger(__name__)
 
 
+def register_projects_long_running_tasks(app: web.Application) -> None:
+    register_create_project_task(app)
+    register_stop_dynamic_service_task(app)
+
+
 @app_module_setup(
     "simcore_service_webserver.projects",
     ModuleCategory.ADDON,
@@ -77,7 +82,4 @@ def setup_projects(app: web.Application) -> bool:
     app.router.add_routes(workspaces_rest.routes)
     app.router.add_routes(trash_rest.routes)
 
-    register_create_project_task(app)
-    register_stop_dynamic_service_task(app)
-
     return True