Skip to content

Commit 8457f2b

Browse files
committed
do not color message
1 parent f3a4541 commit 8457f2b

File tree

3 files changed

+59
-33
lines changed

3 files changed

+59
-33
lines changed
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/* ************************************************************************
2+
3+
osparc - the simcore frontend
4+
5+
https://osparc.io
6+
7+
Copyright:
8+
2024 IT'IS Foundation, https://itis.swiss
9+
10+
License:
11+
MIT: https://opensource.org/licenses/MIT
12+
13+
Authors:
14+
* Ignacio Pascual (ignapas)
15+
16+
************************************************************************ */
17+
18+
/**
19+
* String cell renderer that does not override the cell styles.
20+
*/
21+
qx.Class.define("osparc.ui.table.cellrenderer.String", {
22+
extend: qx.ui.table.cellrenderer.String,
23+
construct: function() {
24+
this.base(arguments);
25+
},
26+
members: {
27+
// Override
28+
_getCellStyle: function(cellInfo) {
29+
const baseStyle = this.base(arguments, cellInfo) || "";
30+
const cellStyle = cellInfo.style || "";
31+
return baseStyle + cellStyle;
32+
}
33+
}
34+
});

services/static-webserver/client/source/class/osparc/widget/logger/LoggerModel.js

Lines changed: 18 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ qx.Class.define("osparc.widget.logger.LoggerModel", {
6161
]);
6262

6363
this.__rawData = [];
64-
65-
const themeManager = qx.theme.manager.Meta.getInstance();
66-
themeManager.addListener("changeTheme", () => this.__themeChanged());
6764
},
6865

6966
properties: {
@@ -81,22 +78,24 @@ qx.Class.define("osparc.widget.logger.LoggerModel", {
8178
},
8279

8380
statics: {
84-
addColorTag: function(msg, color) {
85-
return ("<font color=" + color +">" + msg + "</font>");
86-
},
87-
88-
getLevelColor: function(logLevel) {
89-
const colorManager = qx.theme.manager.Color.getInstance();
90-
let logColor = null;
81+
getLevelIcon: function(logLevel) {
9182
const logLevels = osparc.widget.logger.LoggerView.LOG_LEVELS;
92-
Object.keys(logLevels).forEach(logLevelKey => {
93-
const logString = logLevelKey.toLowerCase();
94-
const logNumber = logLevels[logLevelKey];
95-
if (logNumber === logLevel) {
96-
logColor = colorManager.resolve("logger-"+logString+"-message");
97-
}
98-
});
99-
return logColor ? logColor : colorManager.resolve("logger-info-message");
83+
let iconSource = "";
84+
switch (logLevel) {
85+
case logLevels.DEBUG:
86+
iconSource = "@FontAwesome5Solid/info/12";
87+
break;
88+
case logLevels.INFO:
89+
iconSource = "@FontAwesome5Solid/info/12";
90+
break;
91+
case logLevels.WARNING:
92+
iconSource = "@FontAwesome5Solid/exclamation-triangle/12";
93+
break;
94+
case logLevels.ERROR:
95+
iconSource = "@FontAwesome5Solid/exclamation-circle/12";
96+
break;
97+
}
98+
return iconSource;
10099
}
101100
},
102101

@@ -117,7 +116,7 @@ qx.Class.define("osparc.widget.logger.LoggerModel", {
117116
newRow["level"] = this.self().getLevelIcon(newRow.logLevel);
118117
newRow["time"] = osparc.utils.Utils.formatTime(newRow.timeStamp, true);
119118
newRow["who"] = newRow.label;
120-
newRow["msgRich"] = this.self().addColorTag(newRow.msg, levelColor);
119+
newRow["msgRich"] = newRow.msg;
121120
this.__rawData.push(newRow);
122121
});
123122
},
@@ -131,15 +130,6 @@ qx.Class.define("osparc.widget.logger.LoggerModel", {
131130
});
132131
},
133132

134-
__themeChanged: function() {
135-
this.__rawData.forEach(row => {
136-
const levelColor = this.self().getLevelColor(row.logLevel);
137-
row["time"] = osparc.utils.Utils.formatTime(row.timeStamp, true);
138-
row["who"] = row.label;
139-
row["msgRich"] = this.self().addColorTag(row.msg, levelColor);
140-
});
141-
},
142-
143133
clearTable: function() {
144134
const rawLength = this.__rawData.length;
145135
this.__rawData = [];

services/static-webserver/client/source/class/osparc/widget/logger/LoggerView.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,10 @@ qx.Class.define("osparc.widget.logger.LoggerView", {
8282

8383
statics: {
8484
POS: {
85-
TIMESTAMP: 0,
86-
ORIGIN: 1,
87-
MESSAGE: 2
85+
LOG_LEVEL: 0,
86+
TIMESTAMP: 1,
87+
ORIGIN: 2,
88+
MESSAGE: 3,
8889
},
8990

9091
LOG_LEVELS: {
@@ -277,10 +278,11 @@ qx.Class.define("osparc.widget.logger.LoggerView", {
277278
const colModel = table.getTableColumnModel();
278279
colModel.setDataCellRenderer(this.self().POS.LOG_LEVEL, new qx.ui.table.cellrenderer.Image());
279280
// colModel.setDataCellRenderer(this.self().POS.LOG_LEVEL, new qx.ui.table.cellrenderer.String());
281+
colModel.setDataCellRenderer(this.self().POS.TIMESTAMP, new osparc.ui.table.cellrenderer.String().set({
280282
defaultCellStyle: "user-select: text"
281283
}));
282-
colModel.setDataCellRenderer(this.self().POS.ORIGIN, new qx.ui.table.cellrenderer.Html());
283-
colModel.setDataCellRenderer(this.self().POS.MESSAGE, new osparc.ui.table.cellrenderer.Html().set({
284+
colModel.setDataCellRenderer(this.self().POS.ORIGIN, new qx.ui.table.cellrenderer.String());
285+
colModel.setDataCellRenderer(this.self().POS.MESSAGE, new osparc.ui.table.cellrenderer.String().set({
284286
defaultCellStyle: "user-select: text; text-wrap: wrap"
285287
}));
286288
const resizeBehavior = colModel.getBehavior();

0 commit comments

Comments
 (0)